MyPage Screen UI based on QA

[yuni-ju]

작업 내용

• 마이페이지의 타이틀 텍스트 변경
• 아이콘 크기, 텍스트 크기, 간격 조정

참고

• resolved : [QA] Fix nav_icn in MY #1043
• resolved : [QA] Fix Button in MY #1044
• resolved : [QA] Fix Button in MY #1047
• resolved : [QA] Fix Folder in MY #1048

[coderabbitai]

Caution

Review failed

An error occurred during the review process. Please try again later.

Walkthrough

마이페이지 및 폴더 뷰의 UI 요소 크기와 스타일을 조정하고, 설정 아이콘 드로어블을 새로운 디자인으로 업데이트했습니다. 텍스트 라인높이, 아이콘 크기, 패딩 값 변경 및 아이콘 렌더링 방식(채우기에서 스트로크 기반으로)이 포함됩니다.

Changes

Cohort / File(s)	Summary
MyPage 화면 UI 조정 presentation/src/main/java/daily/dayo/presentation/screen/mypage/MyPageScreen.kt	북마크 아이콘에 명시적 Modifier.size(20.dp) 적용. 새 폴더 추가 아이콘은 12.dp로 크기 조정, 레이블 텍스트 스타일 업그레이드. MyPageTopNavigation 제목 색상을 Gray1_50545B에서 Dark로 변경. 설정 버튼 레이아웃에 padding(end = 8.dp) 추가, 아이콘 모디파이어를 padding(end = 18.dp).size(24.dp)에서 size(44.dp).padding(10.dp)로 변경.
폴더 뷰 텍스트 스타일 presentation/src/main/java/daily/dayo/presentation/view/FolderView.kt	폴더 제목 및 게시물 개수를 표시하는 Text 컴포넌트에 lineHeight = 21.sp 명시적 지정. sp 단위 임포트 추가.
설정 아이콘 드로어블 업데이트 presentation/src/main/res/drawable/ic_setting.xml	벡터 드로어블 크기를 26dp에서 24dp로 축소. 단일 채우기 방식 경로를 두 개의 스트로크 기반 경로(외부 기어 모양, 내부 원형)로 교체. strokeColor="#FF313131", strokeWidth="1.4" 적용.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	PR 제목이 MyPage 화면의 UI 조정이라는 주요 변경사항을 정확히 반영하고 있으며, QA 피드백 기반의 업데이트라는 맥락을 명확히 전달합니다.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch qa/mypage

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

presentation/src/main/java/daily/dayo/presentation/view/FolderView.kt (1)

81-92: lineHeight 값 중복(21.sp)을 상수/토큰으로 정리해 두는 게 안전합니다.

현재 Line 83, Line 90에서 동일 값이 반복되어 추후 타이포 변경 시 누락 위험이 있습니다. 또한 PR 목적상 “folder title”만 조정 의도였다면 Line 90(게시글 수 텍스트) 적용 범위도 QA 기준과 일치하는지 확인해 주세요.

♻️ 제안 diff

+            val folderInfoLineHeight = 21.sp
             Text(
                 text = folder.title,
-                lineHeight = 21.sp,
+                lineHeight = folderInfoLineHeight,
                 style = DayoTheme.typography.b6.copy(Dark)
             )
@@
             Text(
                 text = "${dec.format(folder.postCount)}개",
-                lineHeight = 21.sp,
+                lineHeight = folderInfoLineHeight,
                 style = DayoTheme.typography.b6.copy(Gray3_9FA5AE)
             )

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@presentation/src/main/java/daily/dayo/presentation/view/FolderView.kt` around
lines 81 - 92, Extract the duplicated 21.sp lineHeight used in the two Text
composables into a single constant/token (e.g., FOLDER_LINE_HEIGHT or a
DayoTheme token) and replace the literal 21.sp in the Text showing folder.title
and the Text showing "${dec.format(folder.postCount)}개" with that constant;
while doing so, confirm whether the post-count Text (the one using DecimalFormat
dec and folder.postCount) should share the same line-height per QA and adjust
only if intended. Reference: the two Text composables in FolderView.kt that use
folder.title and the DecimalFormat dec formatting for folder.postCount.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@presentation/src/main/java/daily/dayo/presentation/view/FolderView.kt`:
- Around line 81-92: Extract the duplicated 21.sp lineHeight used in the two
Text composables into a single constant/token (e.g., FOLDER_LINE_HEIGHT or a
DayoTheme token) and replace the literal 21.sp in the Text showing folder.title
and the Text showing "${dec.format(folder.postCount)}개" with that constant;
while doing so, confirm whether the post-count Text (the one using DecimalFormat
dec and folder.postCount) should share the same line-height per QA and adjust
only if intended. Reference: the two Text composables in FolderView.kt that use
folder.title and the DecimalFormat dec formatting for folder.postCount.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 8726aaf5-54c1-40b2-90c3-2c9baf1e157a

📥 Commits

Reviewing files that changed from the base of the PR and between 1b59ea1 and 34b005e.

📒 Files selected for processing (3)

• presentation/src/main/java/daily/dayo/presentation/screen/mypage/MyPageScreen.kt
• presentation/src/main/java/daily/dayo/presentation/view/FolderView.kt
• presentation/src/main/res/drawable/ic_setting.xml