fix(shell): persist pane Map order on drag-and-drop reorder#27
Merged
Conversation
The server-side fix alone was insufficient — the client-side panes Map (which controls remount order) was never reordered on drag-and-drop. When navigating away and back, mount() iterates the Map in insertion order, restoring the original layout. Add _reorderPanesMap() helper that rebuilds the Map in visual order after each drag-and-drop swap and after receiving state:panes-reordered from the server (multi-client sync).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
panesMap (JavaScript Map preserves insertion order) was never reordered after drag-and-drop, somount()reattached panes in the original insertion order when navigating back to Shell_reorderPanesMap()helper that rebuilds the Map in visual order after each drag-and-drop swap and after receivingstate:panes-reorderedfrom the serverTest plan
🤖 Generated with Claude Code