Fixed namespace issue due to roxygenise call#29
Open
ZacharyWaller wants to merge 1 commit intoDasonk:masterfrom
Open
Fixed namespace issue due to roxygenise call#29ZacharyWaller wants to merge 1 commit intoDasonk:masterfrom
ZacharyWaller wants to merge 1 commit intoDasonk:masterfrom
Conversation
|
@Dasonk Can you merge this PR? Available version is currently broken and we have to install this PR |
Owner
I'll look into it when I get home from work. A few years late isn't so bad right? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #28
Since
{roxygen2}7.0.0 (released 2019/11/12)roxygeniseusespkgload::load_all()by default. This ends up loading up thedevtools_shimsnamespace - which includes its own version of the?function.This means that when you load up
{docstring}you can use docstring's version of?but, behind the scenes, it runsroxygenise()which then loads up thedevtools_shimsnamespace. Next time you use?you're running the one loaded up indevtools_shims. This is the source of the error found.Adding the
load = "source"argument in theroxygenise()call bypasses loading up thedevtools_shimsnamespace but still produces the desired behaviour.