Skip to content

🔧 Fix octo-sts pull_request policy subject pattern#4310

Merged
thomas-lebeau merged 1 commit intomainfrom
thomas.lebeau/fix-octo-sts-pull-request-policy
Mar 11, 2026
Merged

🔧 Fix octo-sts pull_request policy subject pattern#4310
thomas-lebeau merged 1 commit intomainfrom
thomas.lebeau/fix-octo-sts-pull-request-policy

Conversation

@thomas-lebeau
Copy link
Collaborator

@thomas-lebeau thomas-lebeau commented Mar 11, 2026

Motivation

The bump-chrome-version CI job (and any other job using getGithubPullRequestToken()) has been failing for months due to a subject format change in GitLab CI. As a result, the Chrome version used in tests has been stuck at 139 for ~7 months.

The error:

trust policy: subject_pattern "project_path:DataDog/browser-sdk:ref_type:branch:ref:main"
did not match "project_path:DataDog/browser-sdk:refs/heads/main"

GitLab updated the default OIDC sub claim format from refs/heads/main to ref_type:branch:ref:main (see GitLab OIDC docs).

Changes

Update .github/chainguard/self.gitlab.pull_request.sts.yaml to use the new subject format, aligning it with the format already used by the release policy.

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.
  • Updated documentation and/or relevant AGENTS.md file

GitLab CI changed the subject format from `refs/heads/main` to
`ref_type:branch:ref:main`. Update the pull_request policy to match,
aligning it with the format already used by the release policy.
@thomas-lebeau thomas-lebeau requested a review from a team as a code owner March 11, 2026 07:51
@thomas-lebeau thomas-lebeau merged commit 0bacc38 into main Mar 11, 2026
22 checks passed
@thomas-lebeau thomas-lebeau deleted the thomas.lebeau/fix-octo-sts-pull-request-policy branch March 11, 2026 10:20
@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants