Release app version after upload by oliverli · Pull Request #273 · DataDog/build-plugins

oliverli · 2026-02-20T07:19:16Z

What and why?

After uploading the built zip archive to Datadog (presumably in a CI environment), also mark that version as the latest released version by making a PUT call to release/live

Making this call in the build script was the best possible move because various configs e.g. the Datadog site is configured in the Datadog vite plugin, which would be non-trivial to extract in a CI script and it would be user-unfriendly to have the user configure that again e.g. in the GH action.

How?

Call /release/live using doRequest after the application has been uploaded

oliverli · 2026-02-20T07:19:32Z

Release app version after upload #273 👈 (View in Graphite)
Allow passing version name via environmental variable to apps plugin #272
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

datadog-official · 2026-02-20T07:22:26Z

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 7d11050 | Docs | Datadog PR Page | Was this helpful? Give us feedback!}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 872da69279

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

packages/plugins/apps/src/upload.ts

yoannmoinet

Two small nits, otherwise looks good.

One note, I'm not sure how we should handle it when the upload succeed but the release does not.
It's fine as is, but maybe something to keep in mind for the future, unless you have an idea now.

packages/plugins/apps/src/upload.test.ts

yoannmoinet · 2026-02-23T14:21:23Z

packages/plugins/apps/src/upload.test.ts

+            expect(getIntakeUrl('datadoghq.com', 'my-app')).toBe(
+                'https://api.datadoghq.com/api/unstable/app-builder-code/apps/my-app/upload',
+            );
            expect(getIntakeUrl('datadoghq.eu', 'my-app')).toBe(
                'https://api.datadoghq.eu/api/unstable/app-builder-code/apps/my-app/upload',
            );
+            expect(getIntakeUrl('ddog-gov.com', 'my-app')).toBe(
+                'https://api.ddog-gov.com/api/unstable/app-builder-code/apps/my-app/upload',
+            );
+            expect(getIntakeUrl('us5.datadoghq.com', 'my-app')).toBe(
+                'https://api.us5.datadoghq.com/api/unstable/app-builder-code/apps/my-app/upload',
+            );
+            expect(getIntakeUrl('dd.datad0g.com', 'my-app')).toBe(
+                'https://api.dd.datad0g.com/api/unstable/app-builder-code/apps/my-app/upload',
+            );


Not sure we need to test for all DD sites.
One should be well enough to verify the string update.
Same for the following test.

Suggested change

expect(getIntakeUrl('datadoghq.com', 'my-app')).toBe(

'https://api.datadoghq.com/api/unstable/app-builder-code/apps/my-app/upload',

);

expect(getIntakeUrl('datadoghq.eu', 'my-app')).toBe(

'https://api.datadoghq.eu/api/unstable/app-builder-code/apps/my-app/upload',

);

expect(getIntakeUrl('ddog-gov.com', 'my-app')).toBe(

'https://api.ddog-gov.com/api/unstable/app-builder-code/apps/my-app/upload',

);

expect(getIntakeUrl('us5.datadoghq.com', 'my-app')).toBe(

'https://api.us5.datadoghq.com/api/unstable/app-builder-code/apps/my-app/upload',

);

expect(getIntakeUrl('dd.datad0g.com', 'my-app')).toBe(

'https://api.dd.datad0g.com/api/unstable/app-builder-code/apps/my-app/upload',

);

expect(getIntakeUrl('datadoghq.eu', 'my-app')).toBe(

'https://api.datadoghq.eu/api/unstable/app-builder-code/apps/my-app/upload',

);

They're all valid DD sites, and imo more tests/more explicit tests are better than fewer

This is just string substitution, apart from adding overhead and unnecessary execution time, there is no added value to test these.

We could test for getIntakeUrl('toto', 'hello') giving us 'https://api.toto/api/unstable/app-builder-code/apps/hello/upload' with the same result in coverage and testing efficiency.

Here, more tests only means more executions for no added value at all.

Co-authored-by: Yoann Moinet <597828+yoannmoinet@users.noreply.github.com>

oliverli · 2026-02-23T23:44:39Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-02-23T23:44:43Z

View all feedbacks in Devflow UI.

2026-02-23 23:44:43 UTC ℹ️ Start processing command /merge

2026-02-23 23:44:48 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2026-02-24 00:54:06 UTC ⚠️ MergeQueue: This merge request was unqueued

oliver.li@datadoghq.com unqueued this merge request

oliverli · 2026-02-24T00:53:59Z

/remove

gh-worker-devflow-routing-ef8351 · 2026-02-24T00:54:02Z

View all feedbacks in Devflow UI.

2026-02-24 00:54:02 UTC ℹ️ Start processing command /remove

2026-02-24 00:54:04 UTC ℹ️ Devflow: /remove

oliverli · 2026-02-24T04:57:35Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-02-24T04:57:39Z

View all feedbacks in Devflow UI.

2026-02-24 04:57:38 UTC ℹ️ Start processing command /merge

2026-02-24 04:57:44 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2026-02-24 09:01:05 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

oliverli · 2026-02-24T15:32:54Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-02-24T15:32:59Z

View all feedbacks in Devflow UI.

2026-02-24 15:32:59 UTC ℹ️ Start processing command /merge

2026-02-24 15:33:06 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2026-02-24 15:35:34 UTC ℹ️ MergeQueue: This merge request was already merged

This pull request was merged directly.

oliverli mentioned this pull request Feb 20, 2026

Allow passing version name via environmental variable to apps plugin #272

Merged

oliverli force-pushed the oliver/release-app-version-after-upload branch from a83fc18 to 35cda9b Compare February 20, 2026 07:53

Base automatically changed from oliver/allow-passing-version-name-via-environmental-variable-to-apps-plugin to master February 20, 2026 19:30

oliverli force-pushed the oliver/release-app-version-after-upload branch from 35cda9b to 78322bb Compare February 20, 2026 19:58

Release app version after upload

872da69

oliverli force-pushed the oliver/release-app-version-after-upload branch from 78322bb to 872da69 Compare February 20, 2026 20:34

oliverli marked this pull request as ready for review February 20, 2026 20:39

oliverli requested a review from yoannmoinet as a code owner February 20, 2026 20:39

chatgpt-codex-connector bot reviewed Feb 20, 2026

View reviewed changes

packages/plugins/apps/src/upload.ts Show resolved Hide resolved

yoannmoinet approved these changes Feb 23, 2026

View reviewed changes

Update packages/plugins/apps/src/upload.test.ts

7d11050

Co-authored-by: Yoann Moinet <597828+yoannmoinet@users.noreply.github.com>

gh-worker-dd-devflow-36fce6 bot added the mergequeue-status: waiting label Feb 23, 2026

gh-worker-dd-devflow-36fce6 bot added mergequeue-status: removed mergequeue-status: waiting and removed mergequeue-status: waiting mergequeue-status: removed labels Feb 24, 2026

gh-worker-dd-devflow-36fce6 bot added mergequeue-status: waiting mergequeue-status: removed and removed mergequeue-status: removed mergequeue-status: waiting labels Feb 24, 2026

gh-worker-dd-devflow-36fce6 bot added mergequeue-status: waiting and removed mergequeue-status: removed labels Feb 24, 2026

yoannmoinet merged commit 6e042b9 into master Feb 24, 2026
5 checks passed

yoannmoinet deleted the oliver/release-app-version-after-upload branch February 24, 2026 15:35

gh-worker-dd-devflow-36fce6 bot added mergequeue-status: done and removed mergequeue-status: waiting labels Feb 24, 2026

Conversation

oliverli commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What and why?

How?

Uh oh!

oliverli commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

datadog-official bot commented Feb 20, 2026 • edited by datadog-datadog-prod-us1 bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

yoannmoinet left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

yoannmoinet Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

oliverli Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

yoannmoinet Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

oliverli commented Feb 23, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 bot commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oliverli commented Feb 24, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 bot commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oliverli commented Feb 24, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 bot commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oliverli commented Feb 24, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 bot commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

oliverli commented Feb 20, 2026 •

edited

Loading

oliverli commented Feb 20, 2026 •

edited

Loading

datadog-official bot commented Feb 20, 2026 •

edited by datadog-datadog-prod-us1 bot

Loading

gh-worker-devflow-routing-ef8351 bot commented Feb 23, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 bot commented Feb 24, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 bot commented Feb 24, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 bot commented Feb 24, 2026 •

edited

Loading