Open
Conversation
fe46585 to
a6557a9
Compare
heyronhay
reviewed
Mar 20, 2026
Collaborator
heyronhay
left a comment
There was a problem hiding this comment.
Looks good overall, one potential issue found.
Comment on lines
+42
to
+44
| async def get_resources(self, client: CustomClient) -> List[Dict]: | ||
| resp = await client.get(self.search_path) | ||
| return resp["data"]["attributes"]["suites"] |
Collaborator
There was a problem hiding this comment.
Can this return paginated results or is it just always just a single list of results?
Contributor
Author
There was a problem hiding this comment.
I see that the endpoint https://api.datadoghq.com/api/v2/synthetics/suites/search could be used with pagination using start (The offset from which to start returning results) and count (The maximum number of results to return) (doc)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing to this repository
What does this PR do?
This PR adds support for syncing Synthetics Test Suites between orgs, ensuring they are replicated with their test references correctly mapped to destination test IDs.
Description of the Change
A test suite is bundle of multiple tests, so we added tests as a dependency of Suites.
We first create tests then tests Suites that check the mapping between the source and destination tests.
Using the v2 Public API https://docs.datadoghq.com/api/latest/synthetics/#create-a-test-suite
Verification Process
--cleanup Truecorrectly deletes it from destinationAdditional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.