chore(ci): add final_status property on junit XML [APMSP-2610]#287
Draft
cbeauchesne wants to merge 3 commits intomainfrom
Draft
chore(ci): add final_status property on junit XML [APMSP-2610]#287cbeauchesne wants to merge 3 commits intomainfrom
cbeauchesne wants to merge 3 commits intomainfrom
Conversation
|
🎯 Code Coverage (details) 🔗 Commit SHA: 45ea450 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #287 +/- ##
=======================================
Coverage 87.76% 87.76%
=======================================
Files 84 84
Lines 5658 5658
=======================================
Hits 4966 4966
Misses 692 692 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a
<property name="dd_tags[test.final_status]" value="pass" />on every test case reported through junitMotivation
Some repositories intentionally use mechanisms that ignore test failures (there are valid reasons to still execute those tests behind the scenes).
In these cases, the reported test status cannot be relied upon by Test Optimization to monitor repository health or trigger team notifications.
To ensure a consistent and unified approach, we will instead use final_status — the property specifically designed and used by the Test Optimization integration for this purpose.
Important note
I'm using the not-that-ideal XSLT here as this change, because it must be done over 17+ repos, and it's a workaround until this gets integrated into a better place, such as datadog-ci or the backend.
We're trying to work with the team on this, please have a look on this RFC for more context.
How to test it ?
Now more
N/Aon the last commit on this queryJira ticket: APMSP-2610