-
Notifications
You must be signed in to change notification settings - Fork 324
Move reactor-core and rective-streams advices to context tracking #10483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
amarziali
wants to merge
4
commits into
master
Choose a base branch
from
andrea.marziali/reactive
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 61 metrics, 10 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~37db8d9b22, baseline=1.59.0-SNAPSHOT~f2f109ef18
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.07 s) : 0, 1069670
Total [baseline] (10.932 s) : 0, 10932214
Agent [candidate] (1.063 s) : 0, 1062884
Total [candidate] (10.86 s) : 0, 10860223
section appsec
Agent [baseline] (1.237 s) : 0, 1236953
Total [baseline] (11.02 s) : 0, 11019886
Agent [candidate] (1.236 s) : 0, 1236224
Total [candidate] (10.989 s) : 0, 10989044
section iast
Agent [baseline] (1.237 s) : 0, 1237497
Total [baseline] (11.258 s) : 0, 11258051
Agent [candidate] (1.237 s) : 0, 1237069
Total [candidate] (11.209 s) : 0, 11208966
section profiling
Agent [baseline] (1.19 s) : 0, 1190423
Total [baseline] (10.939 s) : 0, 10938630
Agent [candidate] (1.19 s) : 0, 1190352
Total [candidate] (10.905 s) : 0, 10904987
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~37db8d9b22, baseline=1.59.0-SNAPSHOT~f2f109ef18
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.18 ms) : 0, 1180
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (631.367 ms) : 0, 631367
BytebuddyAgent [candidate] (627.75 ms) : 0, 627750
AgentMeter [baseline] (28.868 ms) : 0, 28868
AgentMeter [candidate] (28.704 ms) : 0, 28704
GlobalTracer [baseline] (258.943 ms) : 0, 258943
GlobalTracer [candidate] (257.9 ms) : 0, 257900
AppSec [baseline] (33.015 ms) : 0, 33015
AppSec [candidate] (32.58 ms) : 0, 32580
Debugger [baseline] (61.027 ms) : 0, 61027
Debugger [candidate] (62.832 ms) : 0, 62832
Remote Config [baseline] (624.088 µs) : 0, 624
Remote Config [candidate] (601.028 µs) : 0, 601
Telemetry [baseline] (14.638 ms) : 0, 14638
Telemetry [candidate] (11.468 ms) : 0, 11468
Flare Poller [baseline] (4.637 ms) : 0, 4637
Flare Poller [candidate] (4.605 ms) : 0, 4605
section appsec
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.184 ms) : 0, 1184
BytebuddyAgent [baseline] (656.973 ms) : 0, 656973
BytebuddyAgent [candidate] (656.678 ms) : 0, 656678
AgentMeter [baseline] (11.752 ms) : 0, 11752
AgentMeter [candidate] (11.76 ms) : 0, 11760
GlobalTracer [baseline] (258.333 ms) : 0, 258333
GlobalTracer [candidate] (257.962 ms) : 0, 257962
IAST [baseline] (25.199 ms) : 0, 25199
IAST [candidate] (24.98 ms) : 0, 24980
AppSec [baseline] (167.52 ms) : 0, 167520
AppSec [candidate] (167.457 ms) : 0, 167457
Debugger [baseline] (67.246 ms) : 0, 67246
Debugger [candidate] (67.521 ms) : 0, 67521
Remote Config [baseline] (685.954 µs) : 0, 686
Remote Config [candidate] (665.71 µs) : 0, 666
Telemetry [baseline] (9.161 ms) : 0, 9161
Telemetry [candidate] (9.218 ms) : 0, 9218
Flare Poller [baseline] (3.626 ms) : 0, 3626
Flare Poller [candidate] (3.627 ms) : 0, 3627
section iast
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.179 ms) : 0, 1179
BytebuddyAgent [baseline] (800.392 ms) : 0, 800392
BytebuddyAgent [candidate] (799.342 ms) : 0, 799342
AgentMeter [baseline] (11.353 ms) : 0, 11353
AgentMeter [candidate] (11.398 ms) : 0, 11398
GlobalTracer [baseline] (248.576 ms) : 0, 248576
GlobalTracer [candidate] (248.884 ms) : 0, 248884
IAST [baseline] (27.333 ms) : 0, 27333
IAST [candidate] (27.143 ms) : 0, 27143
AppSec [baseline] (33.819 ms) : 0, 33819
AppSec [candidate] (34.088 ms) : 0, 34088
Debugger [baseline] (66.765 ms) : 0, 66765
Debugger [candidate] (66.932 ms) : 0, 66932
Remote Config [baseline] (545.87 µs) : 0, 546
Remote Config [candidate] (572.741 µs) : 0, 573
Telemetry [baseline] (8.667 ms) : 0, 8667
Telemetry [candidate] (8.737 ms) : 0, 8737
Flare Poller [baseline] (3.472 ms) : 0, 3472
Flare Poller [candidate] (3.479 ms) : 0, 3479
section profiling
crashtracking [baseline] (1.219 ms) : 0, 1219
crashtracking [candidate] (1.202 ms) : 0, 1202
BytebuddyAgent [baseline] (683.499 ms) : 0, 683499
BytebuddyAgent [candidate] (682.65 ms) : 0, 682650
AgentMeter [baseline] (8.586 ms) : 0, 8586
AgentMeter [candidate] (8.661 ms) : 0, 8661
GlobalTracer [baseline] (215.468 ms) : 0, 215468
GlobalTracer [candidate] (215.725 ms) : 0, 215725
AppSec [baseline] (32.263 ms) : 0, 32263
AppSec [candidate] (32.278 ms) : 0, 32278
Debugger [baseline] (67.303 ms) : 0, 67303
Debugger [candidate] (67.523 ms) : 0, 67523
Remote Config [baseline] (590.7 µs) : 0, 591
Remote Config [candidate] (592.475 µs) : 0, 592
Telemetry [baseline] (8.793 ms) : 0, 8793
Telemetry [candidate] (8.74 ms) : 0, 8740
Flare Poller [baseline] (3.736 ms) : 0, 3736
Flare Poller [candidate] (3.751 ms) : 0, 3751
ProfilingAgent [baseline] (98.961 ms) : 0, 98961
ProfilingAgent [candidate] (99.378 ms) : 0, 99378
Profiling [baseline] (99.545 ms) : 0, 99545
Profiling [candidate] (99.944 ms) : 0, 99944
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~37db8d9b22, baseline=1.59.0-SNAPSHOT~f2f109ef18
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.071 s) : 0, 1071433
Total [baseline] (8.784 s) : 0, 8783748
Agent [candidate] (1.064 s) : 0, 1064297
Total [candidate] (8.723 s) : 0, 8722827
section iast
Agent [baseline] (1.232 s) : 0, 1232054
Total [baseline] (9.401 s) : 0, 9400791
Agent [candidate] (1.23 s) : 0, 1229631
Total [candidate] (9.377 s) : 0, 9377312
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~37db8d9b22, baseline=1.59.0-SNAPSHOT~f2f109ef18
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.206 ms) : 0, 1206
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (632.576 ms) : 0, 632576
BytebuddyAgent [candidate] (628.432 ms) : 0, 628432
AgentMeter [baseline] (28.884 ms) : 0, 28884
AgentMeter [candidate] (28.613 ms) : 0, 28613
GlobalTracer [baseline] (258.786 ms) : 0, 258786
GlobalTracer [candidate] (257.751 ms) : 0, 257751
AppSec [baseline] (33.154 ms) : 0, 33154
AppSec [candidate] (32.781 ms) : 0, 32781
Debugger [baseline] (60.611 ms) : 0, 60611
Debugger [candidate] (60.921 ms) : 0, 60921
Remote Config [baseline] (629.38 µs) : 0, 629
Remote Config [candidate] (600.433 µs) : 0, 600
Telemetry [baseline] (13.849 ms) : 0, 13849
Telemetry [candidate] (14.049 ms) : 0, 14049
Flare Poller [baseline] (6.202 ms) : 0, 6202
Flare Poller [candidate] (4.569 ms) : 0, 4569
section iast
crashtracking [baseline] (1.209 ms) : 0, 1209
crashtracking [candidate] (1.179 ms) : 0, 1179
BytebuddyAgent [baseline] (798.985 ms) : 0, 798985
BytebuddyAgent [candidate] (795.344 ms) : 0, 795344
AgentMeter [baseline] (11.101 ms) : 0, 11101
AgentMeter [candidate] (11.131 ms) : 0, 11131
GlobalTracer [baseline] (246.853 ms) : 0, 246853
GlobalTracer [candidate] (247.943 ms) : 0, 247943
IAST [baseline] (26.918 ms) : 0, 26918
IAST [candidate] (26.806 ms) : 0, 26806
AppSec [baseline] (34.765 ms) : 0, 34765
AppSec [candidate] (32.868 ms) : 0, 32868
Debugger [baseline] (64.191 ms) : 0, 64191
Debugger [candidate] (66.583 ms) : 0, 66583
Remote Config [baseline] (551.097 µs) : 0, 551
Remote Config [candidate] (536.19 µs) : 0, 536
Telemetry [baseline] (8.608 ms) : 0, 8608
Telemetry [candidate] (8.657 ms) : 0, 8657
Flare Poller [baseline] (3.46 ms) : 0, 3460
Flare Poller [candidate] (3.464 ms) : 0, 3464
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 19 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~37db8d9b22, baseline=1.59.0-SNAPSHOT~f2f109ef18
dateFormat X
axisFormat %s
section baseline
no_agent (18.924 ms) : 18730, 19118
. : milestone, 18924,
appsec (18.724 ms) : 18533, 18914
. : milestone, 18724,
code_origins (17.536 ms) : 17363, 17708
. : milestone, 17536,
iast (17.375 ms) : 17203, 17546
. : milestone, 17375,
profiling (18.653 ms) : 18466, 18839
. : milestone, 18653,
tracing (17.667 ms) : 17489, 17845
. : milestone, 17667,
section candidate
no_agent (18.368 ms) : 18175, 18561
. : milestone, 18368,
appsec (18.381 ms) : 18197, 18565
. : milestone, 18381,
code_origins (17.551 ms) : 17375, 17727
. : milestone, 17551,
iast (17.575 ms) : 17399, 17751
. : milestone, 17575,
profiling (18.699 ms) : 18513, 18886
. : milestone, 18699,
tracing (17.473 ms) : 17302, 17643
. : milestone, 17473,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~37db8d9b22, baseline=1.59.0-SNAPSHOT~f2f109ef18
dateFormat X
axisFormat %s
section baseline
no_agent (1.184 ms) : 1173, 1196
. : milestone, 1184,
iast (3.266 ms) : 3219, 3313
. : milestone, 3266,
iast_FULL (5.81 ms) : 5751, 5870
. : milestone, 5810,
iast_GLOBAL (3.369 ms) : 3315, 3423
. : milestone, 3369,
profiling (2.052 ms) : 2033, 2070
. : milestone, 2052,
tracing (1.822 ms) : 1806, 1838
. : milestone, 1822,
section candidate
no_agent (1.18 ms) : 1168, 1191
. : milestone, 1180,
iast (3.169 ms) : 3124, 3214
. : milestone, 3169,
iast_FULL (5.66 ms) : 5605, 5716
. : milestone, 5660,
iast_GLOBAL (3.58 ms) : 3513, 3647
. : milestone, 3580,
profiling (2.03 ms) : 2012, 2047
. : milestone, 2030,
tracing (1.774 ms) : 1760, 1788
. : milestone, 1774,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~37db8d9b22, baseline=1.59.0-SNAPSHOT~f2f109ef18
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (3.747 ms) : 3526, 3969
. : milestone, 3747,
iast (2.251 ms) : 2182, 2319
. : milestone, 2251,
iast_GLOBAL (2.306 ms) : 2236, 2376
. : milestone, 2306,
profiling (2.1 ms) : 2045, 2156
. : milestone, 2100,
tracing (2.078 ms) : 2025, 2132
. : milestone, 2078,
section candidate
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (2.495 ms) : 2440, 2550
. : milestone, 2495,
iast (2.255 ms) : 2186, 2324
. : milestone, 2255,
iast_GLOBAL (2.3 ms) : 2230, 2369
. : milestone, 2300,
profiling (2.104 ms) : 2047, 2160
. : milestone, 2104,
tracing (2.076 ms) : 2022, 2130
. : milestone, 2076,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~37db8d9b22, baseline=1.59.0-SNAPSHOT~f2f109ef18
dateFormat X
axisFormat %s
section baseline
no_agent (15.583 s) : 15583000, 15583000
. : milestone, 15583000,
appsec (15.163 s) : 15163000, 15163000
. : milestone, 15163000,
iast (18.344 s) : 18344000, 18344000
. : milestone, 18344000,
iast_GLOBAL (17.563 s) : 17563000, 17563000
. : milestone, 17563000,
profiling (14.956 s) : 14956000, 14956000
. : milestone, 14956000,
tracing (14.66 s) : 14660000, 14660000
. : milestone, 14660000,
section candidate
no_agent (15.297 s) : 15297000, 15297000
. : milestone, 15297000,
appsec (14.853 s) : 14853000, 14853000
. : milestone, 14853000,
iast (17.913 s) : 17913000, 17913000
. : milestone, 17913000,
iast_GLOBAL (17.569 s) : 17569000, 17569000
. : milestone, 17569000,
profiling (15.085 s) : 15085000, 15085000
. : milestone, 15085000,
tracing (14.683 s) : 14683000, 14683000
. : milestone, 14683000,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
inst: reactor
Reactor instrumentation
tag: concurrency
Virtual Threads, Coroutines, Async, RX, Executors
tag: no release notes
Changes to exclude from release notes
type: enhancement
Enhancements and improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Also changes the API and the context stores to use generically Context and not span/scopes
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]