Skip to content

Run aggregate_test_counts job on Merge Queue #10954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gh-worker-dd-mergequeue-cf854d merged 2 commits into from
Mar 24, 2026
Merged

Run aggregate_test_counts job on Merge Queue #10954

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d73a3b9
Run aggregate_test_counts job on MQ
sarahchen6 Mar 24, 2026
f7c8b3f
Run on master branch as well
sarahchen6 Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .gitlab-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -809,7 +809,12 @@ aggregate_test_counts:
rules:
- if: '$POPULATE_CACHE'
when: never
- when: always
- if: '$CI_COMMIT_BRANCH == "master"'
when: on_success
- if: '$CI_COMMIT_BRANCH =~ /^mq-working-branch-/'
when: on_success
- if: '$CI_COMMIT_BRANCH =~ /^gh-readonly-queue/'
when: on_success
Comment on lines +816 to +817
Copy link
Contributor

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow I feel this will be never executed? Or am I missing something?
My understanding that GH MQ simply redirects to DD MQ, is that correct?
Also I feel that we may run this on master, but not 100% sure.

Copy link
Contributor

@bric3 bric3 Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's already too late on master only. The idea is to detect early, before impacting master.

Copy link
Contributor Author

@sarahchen6 sarahchen6 Mar 24, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be helpful to have it on master so that we can check what the baseline test count is? For example when comparing your PR's test count to what the "original" master test count is.

And yep the GH MQ line should never run, but we set it for all tests as a catch-all here: https://github.com/DataDog/dd-trace-java/blob/master/.gitlab-ci.yml#L596, so I thought we might as well have it here too.

Copy link
Contributor

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's already too late on master only. The idea is to detect early, before impacting master.

My bad, I ment and on master too :)

script:
- *set_datadog_api_keys
- .gitlab/aggregate_test_counts.sh
Expand Down
Loading