Skip to content

[IGNORE] Community PR 2081#5445

Draft
vpellan wants to merge 30 commits intomasterfrom
community/pr-2081
Draft

[IGNORE] Community PR 2081#5445
vpellan wants to merge 30 commits intomasterfrom
community/pr-2081

Conversation

@vpellan
Copy link
Copy Markdown
Contributor

@vpellan vpellan commented Mar 12, 2026

⚠️ DO NOT MERGE ⚠️

@github-actions github-actions Bot added core Involves Datadog core libraries integrations Involves tracing integrations tracing labels Mar 12, 2026
@github-actions
Copy link
Copy Markdown

👋 Hey @DataDog/ruby-guild, please fill "Change log entry" section in the pull request description.

If changes need to be present in CHANGELOG.md you can state it this way

**Change log entry**

Yes. A brief summary to be placed into the CHANGELOG.md

(possible answers Yes/Yep/Yeah)

Or you can opt out like that

**Change log entry**

None.

(possible answers No/Nope/None)

Visited at: 2026-03-12 17:54:06 UTC

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Mar 12, 2026

Benchmarks

Benchmark execution time: 2026-03-13 16:02:08

Comparing candidate commit 5e392e2 in PR branch community/pr-2081 with baseline commit c5d8dee in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 0 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

@datadog-prod-us1-5
Copy link
Copy Markdown

datadog-prod-us1-5 Bot commented Mar 13, 2026

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
Patch Coverage: 99.09%
Overall Coverage: 95.19% (+0.03%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 5e392e2 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 13, 2026

Typing analysis

Note: Ignored files are excluded from the next sections.

steep:ignore comments

This PR introduces 1 steep:ignore comment.

steep:ignore comments (+1-0)Introduced:
lib/datadog/tracing/contrib/active_storage/integration.rb:36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Involves Datadog core libraries integrations Involves tracing integrations tracing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants