Open
Conversation
prognant
approved these changes
Mar 26, 2020
prognant
left a comment
prognant
left a comment
There was a problem hiding this comment.
LGTM in the extend I think it does what it aims to do. If testing shows the overall performance are not degraded then 👍
Comment on lines
+111
to
+175
| qsize[shard].incrementAndGet(); | ||
| processorWorkQueue[processQueue].offer(shard); |
There was a problem hiding this comment.
Here if I'm correct we are dispatching message to a sharded queue, and those shards are unrelated to processQueue. Did we try 1:1 (or 1:N) mapping between process queues and message queues ? IMHO (unsure) it should (a little bit) ease the concurrency within the JVM.
truthbk
force-pushed
the
jaime/shardlocks
branch
from
8377a81 to
f0f6bf8
Compare
truthbk
force-pushed
the
jaime/shardlocks
branch
from
f0f6bf8 to
bcc863f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.