Open
Conversation
CI Test ResultsRun: #23265404314 | Commit:
Status Overview
Legend: ✅ passed | ❌ failed | ⚪ skipped | 🚫 cancelled Summary: Total: 32 | Passed: 32 | Failed: 0 Updated: 2026-03-18 20:42:24 UTC |
…iler into zgu/refactor-vmstructs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
This is the first part of efforts to eliminating/reducing dependence on jmethodID.
A significant refactoring of vmStructs.cpp/h that replaces ~60 manual if/strcmp chains in initOffsets() with a declarative, macro-driven system (DECLARE_TYPE_FILED_DO). The core design:
Also fixed memory leak and locking bug in
VMStructs::NativeMethodBind()Motivation:
Code cleanup and reduce maintenance cost.
Additional Notes:
Disable verification phase is due to CI failure with JDK25.
Not sure what are the versions of JDK25 used by CI, but I cannot reproduce the verification failure with Zulu, Temurin and JDK25u local build.
How to test the change?:
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!