Skip to content

Remove jvmti wallclock sampler for none J9 VMs#419

Merged
zhengyu123 merged 6 commits intomainfrom
zgu/remove-jvmti-wallclock
Mar 17, 2026
Merged

Remove jvmti wallclock sampler for none J9 VMs#419
zhengyu123 merged 6 commits intomainfrom
zgu/remove-jvmti-wallclock

Conversation

@zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Mar 16, 2026

What does this PR do?:
Remove JVMTI based wallclock support for none J9 VMs

Motivation:
JVMTI based wallclock sampler is not very useful

  • Captured thread may have already exited when sampling
  • Cannot properly propagate context

Remove it and related tests to reduce maintenance cost.

Additional Notes:

How to test the change?:

  • CI tests

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.
  • JIRA: PROF-14004

Unsure? Have a question? Request a review!

@zhengyu123 zhengyu123 changed the title Zgu/remove jvmti wallclock WIP: remove jvmti wallclock Mar 16, 2026
@dd-octo-sts
Copy link

dd-octo-sts bot commented Mar 16, 2026

CI Test Results

Run: #23163367922 | Commit: 1d47ada | Duration: 10m 16s (longest job)

All 32 test jobs passed

Status Overview

JDK glibc-aarch64/debug glibc-amd64/debug musl-aarch64/debug musl-amd64/debug
8 - - -
8-ibm - - -
8-j9 - -
8-librca - -
8-orcl - - -
11 - - -
11-j9 - -
11-librca - -
17 - -
17-graal - -
17-j9 - -
17-librca - -
21 - -
21-graal - -
21-librca - -
25 - -
25-graal - -
25-librca - -

Legend: ✅ passed | ❌ failed | ⚪ skipped | 🚫 cancelled

Summary: Total: 32 | Passed: 32 | Failed: 0


Updated: 2026-03-16 20:16:27 UTC

@pr-commenter
Copy link

pr-commenter bot commented Mar 16, 2026

Integration Tests

All 40 integration tests passed

📊 Dashboard · 👷 Pipeline · 📦 d1348d7c

@zhengyu123 zhengyu123 changed the title WIP: remove jvmti wallclock Remove jvmti wallclock sampler for none J9 VMs Mar 16, 2026
@zhengyu123 zhengyu123 marked this pull request as ready for review March 16, 2026 19:57
@zhengyu123 zhengyu123 requested a review from a team as a code owner March 16, 2026 19:57
Copy link
Collaborator

@jbachorik jbachorik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, follow up in dd-trace-java and remove the experimental config key to enable JVMTI wallclock engine.

@zhengyu123 zhengyu123 merged commit 171c548 into main Mar 17, 2026
83 checks passed
@zhengyu123 zhengyu123 deleted the zgu/remove-jvmti-wallclock branch March 17, 2026 12:42
@github-actions github-actions bot added this to the 1.40.0 milestone Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants