🍒 420 - Intercept sigaction to prevent libraries from overwriting signal handlers#422
Open
jbachorik wants to merge 2 commits intorelease/1.39._from
Open
🍒 420 - Intercept sigaction to prevent libraries from overwriting signal handlers#422jbachorik wants to merge 2 commits intorelease/1.39._from
jbachorik wants to merge 2 commits intorelease/1.39._from
Conversation
Wasmtime's SIGSEGV handler calls malloc() via __tls_get_addr, which is not async-signal-safe and causes deadlocks when profiler uses safefetch. Patch wasmtime's sigaction GOT entry to intercept handler installations. Their handlers are stored as chain targets and called from our handlers. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> (cherry picked from commit 2fcf604)
- Add NATIVE_LIBS_DROPPED counter and LOG_WARN macro - CodeCacheArray::add() returns bool, logs once on overflow - Fix memory leak: delete CodeCache on failed add - Add missing macOS stubs for sigaction protection Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> (cherry picked from commit e35fff9)
3 tasks
CI Test ResultsRun: #23286139431 | Commit:
Status Overview
Legend: ✅ passed | ❌ failed | ⚪ skipped | 🚫 cancelled Summary: Total: 32 | Passed: 32 | Failed: 0 Updated: 2026-03-19 08:38:08 UTC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #420 to
release/1.39._