Simplify review process and remove rescue#1787
Merged
Conversation
Replace the per-call Vec allocation from encode_to_vec() with a RefCell<BytesMut> scratch buffer that persists across calls, matching the pattern already used by OpentelemetryLogs and OpentelemetryMetrics. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…de_to_vec" This reverts commit c009a64.
blt
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Simplifies the optimization skill suite by removing the
lading-optimize-rescueandlading-optimize-validateskills, and streamlining the review process to a binary APPROVED/REJECTED outcome.Motivation
The rescue and validate skills added complexity without proportional value. Bug triage, duplicate detection, and the
bug_found/duplicateverdicts created branching workflows that were rarely exercised. A simpler two-verdict review (APPROVED or REJECTED) covers all cases — duplicates, bugs, and missing benchmarks are all rejections with a descriptive reason.Related issues
N/A
Additional Notes
lading-optimize-rescue,lading-optimize-validatebug-found.template.yaml,duplicate.template.yaml