feat(trace-utils): serialize v04 spans to OTLP#1644
Draft
paullegranddc wants to merge 6 commits intomainfrom
Draft
feat(trace-utils): serialize v04 spans to OTLP#1644paullegranddc wants to merge 6 commits intomainfrom
paullegranddc wants to merge 6 commits intomainfrom
Conversation
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
📚 Documentation Check Results📦
|
🔒 Cargo Deny Results✅ No issues found! 📦
|
paullegranddc
changed the title
paullegranddc
changed the title
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1644 +/- ##
==========================================
+ Coverage 71.19% 71.48% +0.28%
==========================================
Files 425 429 +4
Lines 62666 63461 +795
==========================================
+ Hits 44615 45364 +749
- Misses 18051 18097 +46
🚀 New features to boost your workflow:
|
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a a manual serializer from v04 span model to OTLP spans, using a new proto encoding lib I wrote beforehand.
Motivation
Usually we would use
prostto do such a thing, but it forces you to transform into it's own struct data model before serialization. This is fine if fields map 1:1 but this is not the case here.Furthermore prost only works with
Stringdata, no borrowed slices which is another issue as it would basically require copying all of the data.Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.