Skip to content

fix(obfuscation/memcached): fuzzing fix #1695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gh-worker-dd-mergequeue-cf854d merged 2 commits into from
Mar 10, 2026
Merged

fix(obfuscation/memcached): fuzzing fix #1695

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
120c364
fix(memcached): trim whitespace from result to match Go's strings.Tri…
Eldolfin Mar 5, 2026
5755181
Merge branch 'main' into oscarld/memcached-fuzzing-fixes
Eldolfin Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions libdd-trace-obfuscation/src/memcached.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,8 @@ pub fn obfuscate_memcached_string(cmd: &str) -> String {
// a new line. For non-storage commands, this will have no effect.
// [1]: https://github.com/memcached/memcached/blob/master/doc/protocol.txt
let split: Vec<&str> = cmd.splitn(2, "\r\n").collect();
if let Some(res) = split.first() {
res.to_string()
} else {
cmd.to_string()
}
let res = split.first().copied().unwrap_or(cmd);
res.trim().to_string()
}

#[cfg(test)]
Expand All @@ -29,6 +26,7 @@ mod tests {
[test_obfuscate_memcached_3] ["add newkey 0 60 5\r\nvalue"] ["add newkey 0 60 5"];
[test_obfuscate_memcached_4] ["add newkey 0 60 5\r\nvalue\r\nvalue1"] ["add newkey 0 60 5"];
[test_obfuscate_memcached_5] ["decr mykey 5"] ["decr mykey 5"];
[fuzzing_2126976840] ["\t"] [""];
)]
#[test]
fn test_name() {
Expand Down
Loading