Skip to content

chore(cargo): bump to 29.0.0#1702

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
gyuheon0h/28.1.1
Mar 11, 2026
Merged

chore(cargo): bump to 29.0.0#1702
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
gyuheon0h/28.1.1

Conversation

@gyuheon0h
Copy link
Contributor

@gyuheon0h gyuheon0h commented Mar 11, 2026 •
edited
Loading

What does this PR do?

Bump to 29.0.0

feat(profiling)!: add Tracepoint sample type
[feat(obfuscation/redis): Reach feature parity on redis obfuscation APMSP-2668](#1632)
fix(sidecar): Handle backpressure more gracefully
[feat(trace-protobuf)!: Add two fields to ClientGroupedStats SVLS-8627](#1630)
chore: exclude libdatadog from ADMS auto generated PRs for dependency updates
chore(ci): run crashtracking ffi example tests in CI
fix(crashtracking): use libunwind to unwind frames
feat: publish tracer metadata as OTel process ctx
ci: run thread count test in own process
[feat(obfuscation/json): Init json obfuscation APMSP-2665](#1635)
chore(ci): add final_status property on junit XML [APMSP-2610]
refactor(data-pipeline-ffi): move macro definitions for better reuse
fix(obfuscation/memcached): fuzzing fix
ci: replace use of cargo cross for centos7 tests
#1702 (comment)
feat(stats_exporter)!: add process tags to CSS payloads

Motivation

I mainly am creating this to use the new unwinding from ucontext for crashtracking

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

@gyuheon0h Graphite App
Copy link
Contributor Author

gyuheon0h commented Mar 11, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@gyuheon0h gyuheon0h changed the title 28.1.0 chore(cargo): bump to 29.0.0 Mar 11, 2026
@gyuheon0h gyuheon0h marked this pull request as ready for review March 11, 2026 04:03
@gyuheon0h gyuheon0h requested review from a team as code owners March 11, 2026 04:03
@gyuheon0h gyuheon0h changed the base branch from main to graphite-base/1702 March 11, 2026 04:23
@gyuheon0h gyuheon0h changed the base branch from graphite-base/1702 to gyuheon0h/recursive-checkout-semver March 11, 2026 04:23
@gyuheon0h gyuheon0h mentioned this pull request Mar 11, 2026
Closed
@gyuheon0h gyuheon0h force-pushed the gyuheon0h/recursive-checkout-semver branch from a684205 to 19e7704 Compare March 11, 2026 04:27
@gyuheon0h gyuheon0h force-pushed the gyuheon0h/recursive-checkout-semver branch 2 times, most recently from fc0873e to 6aeb90d Compare March 11, 2026 04:41
@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.25%. Comparing base (e6f8ad8) to head (248d6c4).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1702      +/-   ##
==========================================
+ Coverage   71.16%   71.25%   +0.08%     
==========================================
  Files         429      429              
  Lines       63539    63547       +8     
==========================================
+ Hits        45218    45278      +60     
+ Misses      18321    18269      -52
Components Coverage Δ
libdd-crashtracker 62.40% <ø> (+0.06%) ⬆️
libdd-crashtracker-ffi 17.18% <ø> (+0.61%) ⬆️
libdd-alloc 98.77% <ø> (ø)
libdd-data-pipeline 88.32% <ø> (+0.50%) ⬆️
libdd-data-pipeline-ffi 76.94% <ø> (+2.79%) ⬆️
libdd-common 79.73% <ø> (ø)
libdd-common-ffi 73.40% <ø> (ø)
libdd-telemetry 62.48% <ø> (ø)
libdd-telemetry-ffi 16.75% <ø> (ø)
libdd-dogstatsd-client 82.64% <ø> (ø)
datadog-ipc 80.35% <ø> (ø)
libdd-profiling 81.60% <ø> (ø)
libdd-profiling-ffi 63.65% <ø> (ø)
datadog-sidecar 32.61% <ø> (+0.12%) ⬆️
datdog-sidecar-ffi 8.35% <ø> (+0.53%) ⬆️
spawn-worker 54.69% <ø> (ø)
libdd-tinybytes 93.16% <ø> (ø)
libdd-trace-normalization 81.71% <ø> (ø)
libdd-trace-obfuscation 91.80% <ø> (ø)
libdd-trace-protobuf 68.25% <ø> (ø)
libdd-trace-utils 89.08% <ø> (ø)
datadog-tracer-flare 88.95% <ø> (-1.50%) ⬇️
libdd-log 74.69% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Mar 11, 2026 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2026-03-11 09:58:34

Comparing candidate commit f2de907 in PR branch gyuheon0h/28.1.1 with baseline commit 292a651 in branch gyuheon0h/recursive-checkout-semver.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 2 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f2de907 1773204647 gyuheon0h/28.1.1
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
single_flag_killswitch/rules-based execution_time 190.692ns 193.390ns ± 2.461ns 192.881ns ± 1.500ns 194.397ns 199.076ns 201.035ns 203.616ns 5.57% 1.421 2.138 1.27% 0.174ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
single_flag_killswitch/rules-based execution_time [193.049ns; 193.731ns] or [-0.176%; +0.176%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f2de907 1773204647 gyuheon0h/28.1.1
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 4.976µs 5.053µs ± 0.047µs 5.053µs ± 0.034µs 5.069µs 5.134µs 5.136µs 5.137µs 1.67% 0.381 -0.973 0.93% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.047µs; 5.060µs] or [-0.129%; +0.129%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f2de907 1773204647 gyuheon0h/28.1.1
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 10.646ms 10.674ms ± 0.013ms 10.673ms ± 0.007ms 10.680ms 10.692ms 10.711ms 10.752ms 0.74% 1.802 8.038 0.12% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [10.673ms; 10.676ms] or [-0.016%; +0.016%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f2de907 1773204647 gyuheon0h/28.1.1
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 244.967ns 254.279ns ± 10.690ns 249.645ns ± 3.607ns 256.523ns 281.949ns 285.142ns 288.040ns 15.38% 1.677 1.874 4.19% 0.756ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [252.798ns; 255.761ns] or [-0.583%; +0.583%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f2de907 1773204647 gyuheon0h/28.1.1
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 205.491µs 206.148µs ± 0.360µs 206.082µs ± 0.233µs 206.345µs 206.800µs 207.228µs 207.512µs 0.69% 0.938 0.725 0.17% 0.025µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 4819000.930op/s 4850903.558op/s ± 8467.900op/s 4852442.792op/s ± 5484.204op/s 4857254.321op/s 4861508.436op/s 4863241.612op/s 4866389.335op/s 0.29% -0.929 0.696 0.17% 598.771op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.581µs 18.642µs ± 0.037µs 18.638µs ± 0.019µs 18.657µs 18.695µs 18.767µs 18.891µs 1.36% 2.704 13.759 0.20% 0.003µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 52934714.002op/s 53642517.126op/s ± 106837.284op/s 53654069.479op/s ± 53379.419op/s 53705491.177op/s 53764713.450op/s 53808539.715op/s 53818735.761op/s 0.31% -2.654 13.365 0.20% 7554.537op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.577µs 10.684µs ± 0.037µs 10.684µs ± 0.023µs 10.707µs 10.749µs 10.786µs 10.787µs 0.97% 0.140 0.428 0.35% 0.003µs 1 200
normalization/normalize_name/normalize_name/good throughput 92702212.894op/s 93599793.299op/s ± 324591.940op/s 93601280.811op/s ± 205421.615op/s 93805120.595op/s 94101472.240op/s 94415436.503op/s 94540468.372op/s 1.00% -0.115 0.424 0.35% 22952.116op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [206.098µs; 206.198µs] or [-0.024%; +0.024%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [4849729.989op/s; 4852077.128op/s] or [-0.024%; +0.024%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.637µs; 18.647µs] or [-0.028%; +0.028%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [53627710.506op/s; 53657323.746op/s] or [-0.028%; +0.028%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.679µs; 10.689µs] or [-0.048%; +0.048%] None None None
normalization/normalize_name/normalize_name/good throughput [93554807.978op/s; 93644778.620op/s] or [-0.048%; +0.048%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f2de907 1773204647 gyuheon0h/28.1.1
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
profile_add_sample_frames_x1000 execution_time 4.160ms 4.163ms ± 0.006ms 4.163ms ± 0.001ms 4.164ms 4.167ms 4.169ms 4.244ms 1.96% 11.876 155.144 0.15% 0.000ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
profile_add_sample_frames_x1000 execution_time [4.163ms; 4.164ms] or [-0.020%; +0.020%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f2de907 1773204647 gyuheon0h/28.1.1
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 32.887µs 33.821µs ± 1.267µs 33.040µs ± 0.094µs 35.000µs 36.091µs 36.156µs 36.758µs 11.25% 0.996 -0.865 3.74% 0.090µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [33.645µs; 33.997µs] or [-0.519%; +0.519%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f2de907 1773204647 gyuheon0h/28.1.1
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.219µs 3.238µs ± 1.447µs 2.991µs ± 0.035µs 3.035µs 3.680µs 14.285µs 14.828µs 395.78% 7.232 53.911 44.57% 0.102µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.038µs; 3.439µs] or [-6.192%; +6.192%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f2de907 1773204647 gyuheon0h/28.1.1
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 163.778µs 164.962µs ± 0.318µs 164.949µs ± 0.134µs 165.086µs 165.350µs 165.551µs 167.849µs 1.76% 3.582 33.540 0.19% 0.022µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [164.918µs; 165.006µs] or [-0.027%; +0.027%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f2de907 1773204647 gyuheon0h/28.1.1
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.307µs 2.373µs ± 0.017µs 2.376µs ± 0.009µs 2.384µs 2.390µs 2.394µs 2.397µs 0.86% -2.061 4.851 0.70% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.371µs; 2.375µs] or [-0.097%; +0.097%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f2de907 1773204647 gyuheon0h/28.1.1
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 493.354µs 493.961µs ± 0.423µs 493.926µs ± 0.236µs 494.153µs 494.641µs 494.880µs 497.443µs 0.71% 3.064 21.551 0.09% 0.030µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 2010282.371op/s 2024454.752op/s ± 1730.188op/s 2024594.322op/s ± 969.760op/s 2025567.387op/s 2026643.311op/s 2026803.100op/s 2026940.289op/s 0.12% -3.028 21.164 0.09% 122.343op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 370.018µs 370.590µs ± 0.349µs 370.540µs ± 0.166µs 370.732µs 371.161µs 371.493µs 372.916µs 0.64% 2.635 13.391 0.09% 0.025µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2681566.539op/s 2698401.025op/s ± 2536.975op/s 2698766.183op/s ± 1208.084op/s 2699873.546op/s 2701562.332op/s 2702151.848op/s 2702571.544op/s 0.14% -2.612 13.200 0.09% 179.391op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 167.335µs 167.613µs ± 0.222µs 167.546µs ± 0.103µs 167.696µs 168.055µs 168.304µs 168.900µs 0.81% 2.064 6.371 0.13% 0.016µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5920645.995op/s 5966135.248op/s ± 7897.379op/s 5968503.927op/s ± 3668.113op/s 5971013.507op/s 5974156.812op/s 5975240.590op/s 5976042.740op/s 0.13% -2.048 6.257 0.13% 558.429op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 36.976µs 37.110µs ± 0.066µs 37.097µs ± 0.023µs 37.125µs 37.265µs 37.330µs 37.356µs 0.70% 1.566 3.087 0.18% 0.005µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26769259.065op/s 26947244.542op/s ± 47900.288op/s 26956451.695op/s ± 16612.052op/s 26971179.748op/s 27003377.826op/s 27030894.680op/s 27044625.382op/s 0.33% -1.552 3.048 0.18% 3387.062op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 45.359µs 45.606µs ± 0.132µs 45.613µs ± 0.108µs 45.714µs 45.806µs 45.823µs 45.827µs 0.47% -0.041 -1.167 0.29% 0.009µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 21821048.972op/s 21927348.133op/s ± 63265.587op/s 21923812.096op/s ± 51845.956op/s 21976951.307op/s 22028173.054op/s 22039674.348op/s 22046136.194op/s 0.56% 0.049 -1.166 0.29% 4473.553op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [493.902µs; 494.019µs] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [2024214.964op/s; 2024694.539op/s] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [370.542µs; 370.639µs] or [-0.013%; +0.013%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2698049.425op/s; 2698752.625op/s] or [-0.013%; +0.013%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [167.582µs; 167.644µs] or [-0.018%; +0.018%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5965040.747op/s; 5967229.748op/s] or [-0.018%; +0.018%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [37.100µs; 37.119µs] or [-0.025%; +0.025%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [26940606.022op/s; 26953883.061op/s] or [-0.025%; +0.025%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [45.587µs; 45.624µs] or [-0.040%; +0.040%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [21918580.131op/s; 21936116.135op/s] or [-0.040%; +0.040%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f2de907 1773204647 gyuheon0h/28.1.1
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 48.964ms 49.243ms ± 1.148ms 49.075ms ± 0.034ms 49.120ms 49.332ms 54.193ms 60.368ms 23.01% 8.519 74.452 2.32% 0.081ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [49.084ms; 49.402ms] or [-0.323%; +0.323%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f2de907 1773204647 gyuheon0h/28.1.1
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sdk_test_data/rules-based execution_time 144.553µs 146.450µs ± 1.656µs 146.203µs ± 0.534µs 146.766µs 148.520µs 152.765µs 162.376µs 11.06% 5.461 44.277 1.13% 0.117µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sdk_test_data/rules-based execution_time [146.221µs; 146.680µs] or [-0.157%; +0.157%] None None None

Group 14

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f2de907 1773204647 gyuheon0h/28.1.1
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.895µs 3.916µs ± 0.003µs 3.915µs ± 0.002µs 3.917µs 3.919µs 3.921µs 3.923µs 0.21% -1.817 15.036 0.07% 0.000µs 1 200
credit_card/is_card_number/ throughput 254879332.500op/s 255393406.770op/s ± 178882.639op/s 255402375.283op/s ± 109466.518op/s 255507383.384op/s 255603185.371op/s 255666955.934op/s 256752779.042op/s 0.53% 1.846 15.287 0.07% 12648.913op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 79.617µs 80.143µs ± 0.079µs 80.139µs ± 0.037µs 80.180µs 80.249µs 80.290µs 80.516µs 0.47% -1.833 16.876 0.10% 0.006µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 12419857.146op/s 12477655.594op/s ± 12392.807op/s 12478365.635op/s ± 5737.732op/s 12483905.438op/s 12489726.326op/s 12496229.625op/s 12560160.658op/s 0.66% 1.879 17.103 0.10% 876.304op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 67.824µs 67.902µs ± 0.067µs 67.888µs ± 0.025µs 67.926µs 67.994µs 68.066µs 68.557µs 0.99% 5.135 45.145 0.10% 0.005µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 14586447.121op/s 14727086.031op/s ± 14377.155op/s 14730213.405op/s ± 5367.058op/s 14735110.258op/s 14740122.307op/s 14742143.309op/s 14744097.753op/s 0.09% -5.075 44.318 0.10% 1016.618op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.898µs 3.914µs ± 0.002µs 3.914µs ± 0.001µs 3.915µs 3.919µs 3.920µs 3.920µs 0.17% -0.979 10.347 0.06% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 255069595.564op/s 255478163.098op/s ± 152287.983op/s 255500766.503op/s ± 74998.937op/s 255567782.966op/s 255652723.123op/s 255702170.940op/s 256528164.885op/s 0.40% 0.999 10.491 0.06% 10768.387op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 64.605µs 64.698µs ± 0.060µs 64.681µs ± 0.030µs 64.729µs 64.809µs 64.889µs 64.954µs 0.42% 1.401 2.599 0.09% 0.004µs 1 200
credit_card/is_card_number/378282246310005 throughput 15395486.202op/s 15456326.091op/s ± 14321.197op/s 15460384.311op/s ± 7254.758op/s 15466274.628op/s 15473047.808op/s 15477135.720op/s 15478739.951op/s 0.12% -1.394 2.567 0.09% 1012.662op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 45.424µs 45.699µs ± 0.103µs 45.699µs ± 0.072µs 45.767µs 45.860µs 45.963µs 45.973µs 0.60% 0.149 -0.187 0.23% 0.007µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 21751811.434op/s 21882587.486op/s ± 49365.206op/s 21882541.019op/s ± 34264.982op/s 21917070.114op/s 21955697.433op/s 21995009.850op/s 22014568.216op/s 0.60% -0.137 -0.192 0.23% 3490.647op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.574µs 6.627µs ± 0.014µs 6.633µs ± 0.005µs 6.635µs 6.642µs 6.647µs 6.648µs 0.23% -1.741 3.748 0.20% 0.001µs 1 200
credit_card/is_card_number/x371413321323331 throughput 150426540.379op/s 150887108.402op/s ± 309413.643op/s 150771160.591op/s ± 108842.159op/s 151050689.903op/s 151448336.680op/s 152104281.002op/s 152124773.323op/s 0.90% 1.758 3.825 0.20% 21878.849op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.899µs 3.915µs ± 0.003µs 3.914µs ± 0.001µs 3.916µs 3.921µs 3.923µs 3.924µs 0.24% 0.066 4.621 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 254863334.277op/s 255432947.547op/s ± 190962.747op/s 255465795.225op/s ± 96577.721op/s 255551030.660op/s 255643344.343op/s 255698413.391op/s 256493070.871op/s 0.40% -0.051 4.683 0.07% 13503.105op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 65.590µs 65.704µs ± 0.054µs 65.696µs ± 0.033µs 65.731µs 65.814µs 65.836µs 65.857µs 0.24% 0.611 0.003 0.08% 0.004µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 15184414.717op/s 15219857.048op/s ± 12461.492op/s 15221568.585op/s ± 7609.595op/s 15228995.570op/s 15236373.970op/s 15244678.358op/s 15246185.539op/s 0.16% -0.607 -0.002 0.08% 881.161op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 53.370µs 53.431µs ± 0.077µs 53.421µs ± 0.020µs 53.444µs 53.484µs 53.514µs 54.163µs 1.39% 7.833 69.543 0.14% 0.005µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 18462813.635op/s 18715755.198op/s ± 26656.735op/s 18719372.855op/s ± 7094.860op/s 18725640.948op/s 18732009.922op/s 18735485.872op/s 18737194.797op/s 0.10% -7.789 68.998 0.14% 1884.916op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.897µs 3.915µs ± 0.003µs 3.915µs ± 0.002µs 3.916µs 3.919µs 3.921µs 3.932µs 0.44% 0.069 13.846 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 254332638.622op/s 255444441.682op/s ± 180934.089op/s 255449152.850op/s ± 101558.263op/s 255549416.869op/s 255653979.114op/s 255705830.373op/s 256605585.164op/s 0.45% -0.036 13.873 0.07% 12793.972op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 50.153µs 50.224µs ± 0.038µs 50.223µs ± 0.023µs 50.243µs 50.287µs 50.315µs 50.481µs 0.51% 1.913 9.688 0.08% 0.003µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 19809446.987op/s 19910618.126op/s ± 14957.112op/s 19911345.729op/s ± 8955.140op/s 19921574.738op/s 19929662.045op/s 19934006.478op/s 19938863.457op/s 0.14% -1.895 9.541 0.07% 1057.628op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 45.422µs 45.701µs ± 0.102µs 45.701µs ± 0.068µs 45.773µs 45.864µs 45.937µs 45.966µs 0.58% -0.105 -0.031 0.22% 0.007µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 21755337.881op/s 21881358.482op/s ± 48797.506op/s 21881267.449op/s ± 32308.793op/s 21909652.302op/s 21960929.172op/s 21999010.882op/s 22015723.449op/s 0.61% 0.118 -0.027 0.22% 3450.505op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.569µs 6.627µs ± 0.013µs 6.631µs ± 0.006µs 6.635µs 6.641µs 6.644µs 6.647µs 0.24% -1.644 3.701 0.19% 0.001µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 150439794.960op/s 150899261.797op/s ± 294490.231op/s 150797447.544op/s ± 136826.644op/s 151053464.235op/s 151442719.738op/s 152020812.754op/s 152229052.436op/s 0.95% 1.662 3.790 0.19% 20823.604op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.915µs; 3.916µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/ throughput [255368615.356op/s; 255418198.183op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [80.132µs; 80.154µs] or [-0.014%; +0.014%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12475938.070op/s; 12479373.118op/s] or [-0.014%; +0.014%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [67.893µs; 67.911µs] or [-0.014%; +0.014%] None None None
credit_card/is_card_number/ 378282246310005 throughput [14725093.496op/s; 14729078.566op/s] or [-0.014%; +0.014%] None None None
credit_card/is_card_number/37828224631 execution_time [3.914µs; 3.915µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/37828224631 throughput [255457057.448op/s; 255499268.748op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/378282246310005 execution_time [64.690µs; 64.707µs] or [-0.013%; +0.013%] None None None
credit_card/is_card_number/378282246310005 throughput [15454341.311op/s; 15458310.871op/s] or [-0.013%; +0.013%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [45.684µs; 45.713µs] or [-0.031%; +0.031%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [21875745.943op/s; 21889429.029op/s] or [-0.031%; +0.031%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.626µs; 6.629µs] or [-0.028%; +0.028%] None None None
credit_card/is_card_number/x371413321323331 throughput [150844226.647op/s; 150929990.157op/s] or [-0.028%; +0.028%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.915µs; 3.915µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ throughput [255406481.947op/s; 255459413.147op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [65.696µs; 65.711µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15218130.005op/s; 15221584.091op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [53.420µs; 53.442µs] or [-0.020%; +0.020%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [18712060.831op/s; 18719449.565op/s] or [-0.020%; +0.020%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.914µs; 3.915µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255419365.958op/s; 255469517.407op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [50.219µs; 50.230µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [19908545.214op/s; 19912691.038op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [45.687µs; 45.715µs] or [-0.031%; +0.031%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [21874595.617op/s; 21888121.347op/s] or [-0.031%; +0.031%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.625µs; 6.629µs] or [-0.027%; +0.027%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [150858448.283op/s; 150940075.310op/s] or [-0.027%; +0.027%] None None None

Group 15

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f2de907 1773204647 gyuheon0h/28.1.1
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.843µs 26.504µs ± 9.901µs 18.640µs ± 0.713µs 34.177µs 44.820µs 47.048µs 70.384µs 277.60% 0.953 0.602 37.26% 0.700µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [25.132µs; 27.876µs] or [-5.177%; +5.177%] None None None

Group 16

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f2de907 1773204647 gyuheon0h/28.1.1
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching serializing traces from their internal representation to msgpack execution_time 13.907ms 13.971ms ± 0.033ms 13.968ms ± 0.018ms 13.986ms 14.017ms 14.094ms 14.123ms 1.11% 1.531 4.895 0.24% 0.002ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching serializing traces from their internal representation to msgpack execution_time [13.966ms; 13.976ms] or [-0.033%; +0.033%] None None None

Group 17

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f2de907 1773204647 gyuheon0h/28.1.1
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 88.358µs 88.590µs ± 0.140µs 88.565µs ± 0.070µs 88.647µs 88.792µs 88.895µs 89.952µs 1.57% 4.800 42.618 0.16% 0.010µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [88.570µs; 88.609µs] or [-0.022%; +0.022%] None None None

Group 18

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f2de907 1773204647 gyuheon0h/28.1.1
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
profile_add_sample2_frames_x1000 execution_time 720.910µs 722.478µs ± 0.841µs 722.419µs ± 0.415µs 722.845µs 723.526µs 724.000µs 730.635µs 1.14% 4.611 42.495 0.12% 0.059µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
profile_add_sample2_frames_x1000 execution_time [722.362µs; 722.595µs] or [-0.016%; +0.016%] None None None

Group 19

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f2de907 1773204647 gyuheon0h/28.1.1
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
receiver_entry_point/report/2598 execution_time 3.438ms 3.466ms ± 0.013ms 3.464ms ± 0.008ms 3.474ms 3.492ms 3.503ms 3.508ms 1.28% 0.829 0.628 0.38% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
receiver_entry_point/report/2598 execution_time [3.464ms; 3.468ms] or [-0.052%; +0.052%] None None None

Baseline

Omitted due to size.

@dd-octo-sts
Copy link
Contributor

dd-octo-sts bot commented Mar 11, 2026 •
edited
Loading

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 100.29 MB 100.29 MB +0% (+710 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 8.63 MB 8.63 MB 0% (0 B) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 11.21 MB 11.21 MB 0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 116.96 MB 116.96 MB -0% (-504 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 27.17 MB 27.17 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 76.61 KB 76.61 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 186.04 MB 186.09 MB +.02% (+56.00 KB) 🔍
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 917.15 MB 917.15 MB +0% (+336 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 9.94 MB 9.94 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 76.61 KB 76.61 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 24.77 MB 24.77 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 51.44 MB 51.44 MB +0% (+124 B) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 22.97 MB 22.97 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 77.80 KB 77.80 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 190.25 MB 190.27 MB +.01% (+24.00 KB) 🔍
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 900.81 MB 900.81 MB -0% (-160 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 7.53 MB 7.53 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 77.80 KB 77.80 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 26.52 MB 26.52 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 47.06 MB 47.06 MB -0% (-316 B) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 87.50 MB 87.50 MB -0% (-616 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 10.21 MB 10.21 MB 0% (0 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 109.83 MB 109.83 MB -0% (-120 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 11.95 MB 11.95 MB 0% (0 B) 👌

@github-actions
Copy link

github-actions bot commented Mar 11, 2026

Clippy Allow Annotation Report

Comparing clippy allow annotations between branches:

Summary by Rule

Rule Base Branch PR Branch Change

Annotation Counts by File

File Base Branch PR Branch Change

Annotation Stats by Crate

Crate Base Branch PR Branch Change
clippy-annotation-reporter 5 5 No change (0%)
datadog-ffe-ffi 1 1 No change (0%)
datadog-ipc 28 28 No change (0%)
datadog-live-debugger 6 6 No change (0%)
datadog-live-debugger-ffi 10 10 No change (0%)
datadog-profiling-replayer 4 4 No change (0%)
datadog-remote-config 3 3 No change (0%)
datadog-sidecar 59 59 No change (0%)
libdd-common 10 10 No change (0%)
libdd-common-ffi 12 12 No change (0%)
libdd-data-pipeline 5 5 No change (0%)
libdd-ddsketch 2 2 No change (0%)
libdd-dogstatsd-client 1 1 No change (0%)
libdd-profiling 13 13 No change (0%)
libdd-telemetry 19 19 No change (0%)
libdd-tinybytes 4 4 No change (0%)
libdd-trace-normalization 2 2 No change (0%)
libdd-trace-obfuscation 9 9 No change (0%)
libdd-trace-utils 15 15 No change (0%)
Total 208 208 No change (0%)

About This Report

This report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality.

@gyuheon0h gyuheon0h changed the base branch from gyuheon0h/recursive-checkout-semver to gleocadie/fix-semver-check March 11, 2026 12:50
@gyuheon0h gyuheon0h requested a review from a team as a code owner March 11, 2026 12:50
Base automatically changed from gleocadie/fix-semver-check to main March 11, 2026 13:20
gleocadie
gleocadie reviewed Mar 11, 2026
View reviewed changes
@gyuheon0h gyuheon0h requested a review from gleocadie March 11, 2026 15:30
@gh-worker-ownership-write-b05516 gh-worker-ownership-write-b05516 bot removed the request for review from a team March 11, 2026 17:31
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot merged commit 001bd56 into main Mar 11, 2026
90 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot deleted the gyuheon0h/28.1.1 branch March 11, 2026 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gleocadie gleocadie gleocadie approved these changes

Assignees

No one assigned

Labels

crashtracker mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gyuheon0h @codecov-commenter @gleocadie