Conversation
|
|
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: f0c89d3 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
adeshkumar1
force-pushed
the
cpp-kong-version-correction
branch
from
768f677 to
c3513b5
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c4894cc28d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| git clone --depth 1 --branch "$LIBRARY_TARGET_BRANCH" \ | ||
| https://github.com/DataDog/kong-plugin-ddtrace.git kong-plugin-ddtrace |
There was a problem hiding this comment.
The new cpp_kong path always executes git clone ... kong-plugin-ddtrace, but there is no cleanup/update path when that directory already exists from a previous run. In that local workflow (for example, rerunning with a different LIBRARY_TARGET_BRANCH), git clone fails with destination path 'kong-plugin-ddtrace' already exists and is not an empty directory, so the script cannot refresh the binary without manual directory deletion.
Useful? React with 👍 / 👎.
adeshkumar1
force-pushed
the
cpp-kong-version-correction
branch
from
c4894cc to
0435fff
Compare
|
/remove |
|
View all feedbacks in Devflow UI.
|
gh-worker-dd-devflow-36fce6
bot
added
mergequeue-status: removed
and removed
mergequeue-status: waiting
labels
adeshkumar1
force-pushed
the
cpp-kong-version-correction
branch
3 times, most recently
from
41e30ee to
7452b91
Compare
| PLUGIN_VERSION=$(grep -oP 'VERSION\s*=\s*"\K[^"]+' \ | ||
| kong-plugin-ddtrace/kong/plugins/ddtrace/handler.lua) | ||
|
|
||
| if [ -d kong-plugin-ddtrace/.git ]; then |
There was a problem hiding this comment.
When running from release, the repo will be also present, and the -dev pre-release tag will be added, see https://github.com/DataDog/system-tests/actions/runs/22676081296/job/65767017910?pr=6409#step:19:22
adeshkumar1
force-pushed
the
cpp-kong-version-correction
branch
from
3ad0b60 to
ee4d5b3
Compare
|
FYI: v0.2.4 is now the latest official release for |
adeshkumar1
force-pushed
the
cpp-kong-version-correction
branch
from
ee4d5b3 to
07731f4
Compare
|
Converting to draft to unstress my notifications queue, please set it back to normal once i's readuy for review |
adeshkumar1
force-pushed
the
cpp-kong-version-correction
branch
from
07731f4 to
b1a8131
Compare
adeshkumar1
force-pushed
the
cpp-kong-version-correction
branch
from
b1a8131 to
f0c89d3
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f0c89d3ebf
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if [ "$KONG_IS_RELEASE" = "false" ]; then | ||
| auth_header=$(get_authentication_header) | ||
| COMMIT_SHA=$(eval "curl --silent --fail --retry 3 $auth_header \ | ||
| https://api.github.com/repos/DataDog/kong-plugin-ddtrace/commits/main" \ |
There was a problem hiding this comment.
load-binary.sh now supports LIBRARY_TARGET_BRANCH for cpp_kong, but the version suffix logic here always reads DataDog/kong-plugin-ddtrace/commits/main, so the emitted SYSTEM_TESTS_LIBRARY_VERSION can point to a different revision than the plugin actually copied into the image whenever a non-main branch is tested (or main moves between clone and build). That mislabels build metadata and can misattribute experiment results during triage.
Useful? React with 👍 / 👎.
| git clone --depth 1 --branch "$LIBRARY_TARGET_BRANCH" \ | ||
| https://github.com/DataDog/kong-plugin-ddtrace.git kong-plugin-ddtrace |
There was a problem hiding this comment.
This new clone path does not remove existing kong-plugin-ddtrace*.rock files from prior runs, and install_ddtrace.sh still prioritizes .rock artifacts over kong-plugin-ddtrace/ when both are present. In that common rerun scenario, the build silently uses the stale rock instead of the freshly cloned branch, so tests run against unintended plugin code.
Useful? React with 👍 / 👎.
2 participants
load-binary.sh: Clone frommaininstead of downloadingtip.rock. Supports$LIBRARY_TARGET_BRANCH.install_ddtrace.sh: Fallback downloads latest release as a source tarball instead of git cloning. Only dev builds (with.gitpresent) get the-dev+<sha>version suffix.