Skip to content

Remove obsolete ref_protected from STS trust policies#6436

Open
d-niu wants to merge 1 commit intomainfrom
remove-ref-protected-from-sts-policies
Open

Remove obsolete ref_protected from STS trust policies#6436
d-niu wants to merge 1 commit intomainfrom
remove-ref-protected-from-sts-policies

Conversation

@d-niu
Copy link

@d-niu d-niu commented Mar 4, 2026

Summary

  • Remove ref_protected: "true" from dd-octo-sts trust policy claim patterns

The ref_protected OIDC claim is now obsolete in the DataDog org:

  • GitHub: The org-level "incompatible file paths on windows" push ruleset causes ALL branches to report ref_protected: true in OIDC tokens, making it useless as a security signal
  • GitLab: All branches on gitlab.ddbuild.io report ref_protected: true due to org-level pushAccessLevels: 40 config

Since the claim is universally true, it provides no actual filtering — only a false sense of security. Removing it has zero functional impact on policy enforcement.

All other constraints (subject, ref, job_workflow_ref, project_path, pipeline_source, etc.) remain unchanged and continue to provide the real security boundaries.

Ticket: https://datadoghq.atlassian.net/browse/SINT-4732

Test plan

  • Verify that the remaining policy constraints are sufficient (ref, job_workflow_ref, etc. are unchanged)
  • No functional change expected since ref_protected was already always true

🤖 Generated with Claude Code

The `ref_protected` OIDC claim is now universally `true` in the DataDog org
due to the org-level "incompatible file paths on windows" push ruleset,
making it useless as a security discriminator.

Ticket: https://datadoghq.atlassian.net/browse/SINT-4732

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@d-niu d-niu requested a review from a team as a code owner March 4, 2026 22:37
@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026

CODEOWNERS have been resolved as:

.github/chainguard/self.changelog.sts.yaml                              @DataDog/system-tests-core
.github/chainguard/self.gitlab-read.sts.yaml                            @DataDog/system-tests-core
.github/chainguard/self.k8s_components.sts.yaml                         @DataDog/system-tests-core
.github/chainguard/self.update-agent-protobuf.create-pr.sts.yaml        @DataDog/system-tests-core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants