Skip to content

Adding doc string to const group definitions#6458

Open
nccatoni wants to merge 5 commits intomainfrom
nccatoni/const-docstring
Open

Adding doc string to const group definitions#6458
nccatoni wants to merge 5 commits intomainfrom
nccatoni/const-docstring

Conversation

@nccatoni
Copy link
Collaborator

Motivation

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions
Copy link
Contributor

CODEOWNERS have been resolved as:

utils/const/_const.py                                                   @DataDog/system-tests-core

@nccatoni nccatoni marked this pull request as ready for review March 10, 2026 09:56
@nccatoni nccatoni requested a review from a team as a code owner March 10, 2026 09:56
Copy link
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small precisions.

@robertomonteromiguel , could you do the same for ssi and libinjection?

nccatoni and others added 2 commits March 10, 2026 11:19
Co-authored-by: Charles de Beauchesne <charles.debeauchesne@datadoghq.com>
Co-authored-by: Charles de Beauchesne <charles.debeauchesne@datadoghq.com>
nccatoni and others added 2 commits March 10, 2026 16:27
Co-authored-by: Roberto Montero <108007532+robertomonteromiguel@users.noreply.github.com>
Co-authored-by: Roberto Montero <108007532+robertomonteromiguel@users.noreply.github.com>
@datadog-datadog-prod-us1-2
Copy link

datadog-datadog-prod-us1-2 bot commented Mar 10, 2026

⚠️ Tests

Fix all issues with BitsAI or with Cursor

⚠️ Warnings

🧪 2 Tests failed

tests.debugger.test_debugger_exception_replay.Test_Debugger_Exception_Replay.test_exception_replay_rockpaperscissors[spring-boot] from system_tests_suite (Datadog) (Fix with Cursor)
AssertionError: assert [{'captures':... 'java', ...}] == [{'captures':... 'java', ...}]
  At index 1 diff: {'captures': {'entry': {'arguments': {}, 'locals': {}, 'staticFields': {}}, 'return': {'arguments': {'shape': {'type': 'java.lang.String', 'value': 'rock'}, 'this': {'type': 'com.datadoghq.system_tests.springboot.debugger.ExceptionReplayController', 'fields': {}}}, 'locals': {}, 'staticFields': {}, 'throwable': {'type': 'com.datadoghq.system_tests.springboot.debugger.ExceptionReplayRock', 'message': 'Rock exception', 'stacktrace': [{'function': 'com.datadoghq.system_tests.springboot.debugger.ExceptionReplayController.exceptionReplayRockPaperScissors', 'lineNumber': 41}, {'function': 'datadog.trace.instrumentation.springweb.HandlerMappingResourceNameFilter.doFilterInternal', 'lineNumber': 57}, {'<runtime>': '<scrubbed>'}]}}}, 'exceptionId': '<scrubbed>', 'id': '<scrubbed>', 'language': 'java', 'probe': {'id': '<scrubbed>', 'version': 0, 'location': {'lines': [], 'method': 'exceptionReplayRockPaperScissors', 'type': 'com.datadoghq.system_tests.springboot.debugger.ExceptionReplayController'}}, 'stack': [{'function': 'com.datadoghq.system_tests.springboot.debugger.ExceptionReplayController.exceptionReplayRockPaperScissors', 'lineNumber': 52}, {'function': 'datadog.trace.instrumentation.springweb.HandlerMappingResourceNameFilter.doFilterInternal', 'lineNumber': 57}, {'<runtime>': '<scrubbed>'}], 'timestamp': '<scrubbed>'} != {'captures': {'entry': {'arguments': {}, 'locals': {}, 'staticFields': {}}, 'return': {'arguments': {'shape': {'type': 'java.lang.String', 'value': 'scissors'}, 'this': {'type': 'com.datadoghq.system_tests.springboot.debugger.ExceptionReplayController', 'fields': {}}}, 'locals': {}, 'staticFields': {}, 'throwable': {'type': 'com.datadoghq.system_tests.springboot.debugger.ExceptionReplayScissors', 'message': 'Scissors exception', 'stacktrace': [{'function': 'com.datadoghq.system_tests.springboot.debugger.ExceptionReplayController.exceptionReplayRockPaperScissors', 'lineNumber': 49}, {'function': 'datadog.trace.instrumentation.springweb.HandlerMappingResourceNameFilter.doFilterInternal', 'lineNumber': 57}, {'<runtime>': '<scrubbed>'}]}}}, 'exceptionId': '<scrubbed>', 'id': '<scrubbed>', 'language': 'java', 'probe': {'id': '<scrubbed>', 'version': 0, 'location': {'lines': [], 'method': 'exceptionReplayRockPaperScissors', 'type': 'com.datadoghq.system_tests.springboot.debugger.ExceptionReplayController'}}, 'stack': [{'function': 'com.datadoghq.system_tests.springboot.debugger.ExceptionReplayController.exceptionReplayRockPaperScissors', 'lineNumber': 52}, {'function': 'datadog.trace.instrumentation.springweb.HandlerMappingResourceNameFilter.doFilterInternal', 'lineNumber': 57}, {'<runtime>': '<scrubbed>'}], 'timestamp': '<scrubbed>'}
  Left contains one more item: {'captures': {'entry': {'arguments': {}, 'locals': {}, 'staticFields': {}}, 'return': {'arguments': {'shape': {'type':...ingboot.debugger.ExceptionReplayScissors'}}}, 'exceptionId': '<scrubbed>', 'id': '<scrubbed>', 'language': 'java', ...}
  Full diff:
    [
     {'captures': {'entry': {'arguments': {},
                             'locals': {},
                             'staticFields': {}},
                   'return': {'arguments': {'shape': {'type': 'java.lang.String',
                                                      'value': 'paper'},
...
tests.debugger.test_debugger_probe_snapshot.Test_Debugger_Method_Probe_Snaphots.test_mix_snapshot[poc] from system_tests_suite (Datadog) (Fix with Cursor)
AssertionError: assert 'Snapshot was not received' is None
 +  where 'Snapshot was not received' = <built-in method join of str object at 0x7f1d9102aa60>(['Snapshot was not received'])
 +    where <built-in method join of str object at 0x7f1d9102aa60> = '\n'.join
 +    and   ['Snapshot was not received'] = <tests.debugger.test_debugger_probe_snapshot.Test_Debugger_Method_Probe_Snaphots object at 0x7f1d82fa41d0>.setup_failures

self = <tests.debugger.test_debugger_probe_snapshot.Test_Debugger_Method_Probe_Snaphots object at 0x7f1d82fa41d0>

    @slow
    def test_mix_snapshot(self):
>       self._assert()
...

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: a96d8a8 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants