[dotnet@maximo/enable-runtime-metrics-default] Update .NET Runtime Metrics Default to true

[link04]

Motivation

For .NET we are changing the default of DD_RUNTIME_METRICS_ENABLED to true starting .NET 6+.

Changes

Updated SDK_DEFAULT_STABLE_CONFIG to add true for .NET.

Workflow

1. ⚠️ Create your PR as draft ⚠️
2. Work on you PR until the CI passes
3. Mark it as ready for review
   • Test logic is modified? -> Get a review from RFC owner.
   • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

• Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
• A docker base image is modified?
  • the relevant build-XXX-image label is present
• A scenario is added, removed or renamed?
  • Get a review from R&P team

[github-actions]

CODEOWNERS have been resolved as:

tests/parametric/test_config_consistency.py                             @DataDog/apm-sdk-capabilities

[datadog-prod-us1-5]

⚠️ Tests

✨ Fix all issues with BitsAI or with Cursor

⚠️ Warnings

🧪 10 Tests failed

tests.parametric.test_config_consistency.Test_Stable_Config_Default.test_default_config[/etc/datadog-agent/application_monitoring.yaml-data_streams-apm_configuration_default2-expected2-library_env0, parametric-dotnet] from system_tests_suite (Datadog) (Fix with Cursor)

AssertionError: assert dict_items([('dd_runtime_metrics_enabled', 'true'), ('dd_profiling_enabled', 'false'), ('dd_data_streams_enabled', 'true'), ('dd_logs_injection', 'true')]) <= dict_items([('dd_service', None), ('dd_log_level', None), ('dd_trace_sample_rate', None), ('dd_trace_enabled', 'true')...d_port', None), ('dd_logs_injection', 'true'), ('dd_profiling_enabled', 'false'), ('dd_data_streams_enabled', 'true')])
 +  where dict_items([('dd_runtime_metrics_enabled', 'true'), ('dd_profiling_enabled', 'false'), ('dd_data_streams_enabled', 'true'), ('dd_logs_injection', 'true')]) = <built-in method items of dict object at 0x7fa837d1c780>()
 +    where <built-in method items of dict object at 0x7fa837d1c780> = {'dd_data_streams_enabled': 'true', 'dd_logs_injection': 'true', 'dd_profiling_enabled': 'false', 'dd_runtime_metrics_enabled': 'true'}.items
 +  and   dict_items([('dd_service', None), ('dd_log_level', None), ('dd_trace_sample_rate', None), ('dd_trace_enabled', 'true')...d_port', None), ('dd_logs_injection', 'true'), ('dd_profiling_enabled', 'false'), ('dd_data_streams_enabled', 'true')]) = <built-in method items of dict object at 0x7fa834d71680>()
 +    where <built-in method items of dict object at 0x7fa834d71680> = {'dd_data_streams_enabled': 'true', 'dd_dogstatsd_host': None, 'dd_dogstatsd_port': None, 'dd_env': None, ...}.items

self = <tests.parametric.test_config_consistency.Test_Stable_Config_Default object at 0x7fa837c72510>
test_library = <utils.docker_fixtures._test_clients._test_client_parametric.ParametricTestClientApi object at 0x7fa8031e3d70>
path = '/etc/datadog-agent/application_monitoring.yaml', name = 'data_streams'
apm_configuration_default = {'DD_DATA_STREAMS_ENABLED': True}
...

tests.parametric.test_config_consistency.Test_Stable_Config_Default.test_default_config[/etc/datadog-agent/application_monitoring.yaml-logs_injection-apm_configuration_default3-expected3-library_env0, parametric-dotnet] from system_tests_suite (Datadog) (Fix with Cursor)

AssertionError: assert dict_items([('dd_runtime_metrics_enabled', 'true'), ('dd_profiling_enabled', 'false'), ('dd_data_streams_enabled', 'true'), ('dd_logs_injection', 'true')]) <= dict_items([('dd_service', None), ('dd_log_level', None), ('dd_trace_sample_rate', None), ('dd_trace_enabled', 'true')...d_port', None), ('dd_logs_injection', 'true'), ('dd_profiling_enabled', 'false'), ('dd_data_streams_enabled', 'true')])
 +  where dict_items([('dd_runtime_metrics_enabled', 'true'), ('dd_profiling_enabled', 'false'), ('dd_data_streams_enabled', 'true'), ('dd_logs_injection', 'true')]) = <built-in method items of dict object at 0x7fa837d1c140>()
 +    where <built-in method items of dict object at 0x7fa837d1c140> = {'dd_data_streams_enabled': 'true', 'dd_logs_injection': 'true', 'dd_profiling_enabled': 'false', 'dd_runtime_metrics_enabled': 'true'}.items
 +  and   dict_items([('dd_service', None), ('dd_log_level', None), ('dd_trace_sample_rate', None), ('dd_trace_enabled', 'true')...d_port', None), ('dd_logs_injection', 'true'), ('dd_profiling_enabled', 'false'), ('dd_data_streams_enabled', 'true')]) = <built-in method items of dict object at 0x7fa8059ebe80>()
 +    where <built-in method items of dict object at 0x7fa8059ebe80> = {'dd_data_streams_enabled': 'true', 'dd_dogstatsd_host': None, 'dd_dogstatsd_port': None, 'dd_env': None, ...}.items

self = <tests.parametric.test_config_consistency.Test_Stable_Config_Default object at 0x7fa837c725a0>
test_library = <utils.docker_fixtures._test_clients._test_client_parametric.ParametricTestClientApi object at 0x7fa803306b40>
path = '/etc/datadog-agent/application_monitoring.yaml', name = 'logs_injection'
apm_configuration_default = {'DD_LOGS_INJECTION': True}
...

tests.parametric.test_config_consistency.Test_Stable_Config_Default.test_default_config[/etc/datadog-agent/application_monitoring.yaml-profiling-apm_configuration_default0-expected0-library_env0, parametric-dotnet] from system_tests_suite (Datadog) (Fix with Cursor)

AssertionError: assert dict_items([('dd_runtime_metrics_enabled', 'true'), ('dd_profiling_enabled', 'true'), ('dd_data_streams_enabled', 'true'), ('dd_logs_injection', 'true')]) <= dict_items([('dd_service', None), ('dd_log_level', None), ('dd_trace_sample_rate', None), ('dd_trace_enabled', 'true')...sd_port', None), ('dd_logs_injection', 'true'), ('dd_profiling_enabled', 'true'), ('dd_data_streams_enabled', 'true')])
 +  where dict_items([('dd_runtime_metrics_enabled', 'true'), ('dd_profiling_enabled', 'true'), ('dd_data_streams_enabled', 'true'), ('dd_logs_injection', 'true')]) = <built-in method items of dict object at 0x7fa837d1c640>()
 +    where <built-in method items of dict object at 0x7fa837d1c640> = {'dd_data_streams_enabled': 'true', 'dd_logs_injection': 'true', 'dd_profiling_enabled': 'true', 'dd_runtime_metrics_enabled': 'true'}.items
 +  and   dict_items([('dd_service', None), ('dd_log_level', None), ('dd_trace_sample_rate', None), ('dd_trace_enabled', 'true')...sd_port', None), ('dd_logs_injection', 'true'), ('dd_profiling_enabled', 'true'), ('dd_data_streams_enabled', 'true')]) = <built-in method items of dict object at 0x7fa8034d6a40>()
 +    where <built-in method items of dict object at 0x7fa8034d6a40> = {'dd_data_streams_enabled': 'true', 'dd_dogstatsd_host': None, 'dd_dogstatsd_port': None, 'dd_env': None, ...}.items

self = <tests.parametric.test_config_consistency.Test_Stable_Config_Default object at 0x7fa837c72390>
test_library = <utils.docker_fixtures._test_clients._test_client_parametric.ParametricTestClientApi object at 0x7fa8033cb4a0>
path = '/etc/datadog-agent/application_monitoring.yaml', name = 'profiling'
apm_configuration_default = {'DD_PROFILING_ENABLED': True}
...

View all

ℹ️ Info

❄️ No new flaky tests detected

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 8c5df2a | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!}

[bm1549]

Approving so you can easily merge when it's ready