Skip to content

suggestion: split out csv decoding from file reading #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mcoady wants to merge 3 commits into
base: main
Choose a base branch
from
+6 −2
Open

suggestion: split out csv decoding from file reading #143

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8cb40d1
fix broken `cabal build` in Windows
mcoady Jan 28, 2026
838c46e
spin out `decodeSeparated` from `readSeparated`
mcoady Jan 28, 2026
403af85
Merge branch 'DataHaskell:main' into main
mcoady Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/DataFrame/IO/CSV.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,10 +237,14 @@ ghci> D.readSeparated (D.defaultReadOptions { columnSeparator = ';' }) ".\/data\
@
-}
readSeparated :: ReadOptions -> FilePath -> IO DataFrame
readSeparated !opts !path = do
let sep = columnSeparator opts
readSeparated opts !path = do
let stripUtf8Bom bs = fromMaybe bs (BL.stripPrefix "\xEF\xBB\xBF" bs)
csvData <- stripUtf8Bom <$> BL.readFile path
decodeSeparated opts csvData

decodeSeparated :: ReadOptions -> BL.ByteString -> IO DataFrame
decodeSeparated !opts csvData = do
let sep = columnSeparator opts
let decodeOpts = Csv.defaultDecodeOptions{Csv.decDelimiter = fromIntegral (ord sep)}
let stream = CsvStream.decodeWith decodeOpts Csv.NoHeader csvData

Expand Down