Override AbstractJdbcDriver method getTable The default method takes …#3148
Open
yangzehan wants to merge 6 commits intoDataLinkDC:devfrom
Open
Override AbstractJdbcDriver method getTable The default method takes …#3148yangzehan wants to merge 6 commits intoDataLinkDC:devfrom
yangzehan wants to merge 6 commits intoDataLinkDC:devfrom
Conversation
…longer to filter after obtaining listTables
…longer to filter after obtaining listTables
github-actions
bot
requested review from
Zzm0809,
aiwenmo,
gaoyan1998 and
zackyoungh
Zzm0809
reviewed
Feb 6, 2024
| import static org.dinky.utils.SplitUtil.contains; | ||
| import static org.dinky.utils.SplitUtil.getReValue; | ||
| import static org.dinky.utils.SplitUtil.isSplit; | ||
| import static org.dinky.utils.SplitUtil.*; |
aiwenmo
requested changes
Feb 6, 2024
Contributor
aiwenmo
left a comment
aiwenmo
left a comment
There was a problem hiding this comment.
Please consider the situation where the data source does not support jdbc.
Contributor
Author
Now all drivers inherit AbstractJdbcDriver. if jdbc is not supported, the method can be overridden |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
原方法需要获取数据库中全部表的元数据再过滤比较花费时间