[codex] switch to environment.yaml activation contract#216
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 28cf74d9e6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if [[ -f "$BLOOM_ROOT/environment.yaml" ]]; then | ||
| echo -e " ${_CYAN}→${_NC} Installing conda environment from environment.yaml..." | ||
| if conda env create -n "${_BLOOM_CONDA_ENV_NAME}" -f "$BLOOM_ROOT/environment.yaml"; then |
There was a problem hiding this comment.
Switching activation to environment.yaml and deleting bloom_env.yaml leaves GitHub Actions pointing at a file that no longer exists (.github/workflows/ci.yml:177 still sets environment-file: bloom_env.yaml). In this state, the test job cannot create its conda env on a fresh runner, so CI will fail immediately after this migration unless the workflow is updated in the same change.
Useful? React with 👍 / 👎.
| - sqlalchemy>=2.0.23 | ||
| - starlette>=0.35.1 | ||
| - uvicorn>=0.28.0 | ||
| - zebra-day==3.5.2 |
There was a problem hiding this comment.
The new conda contract pins zebra-day==3.5.2, but the package metadata still requires zebra-day==4.0.0 in pyproject.toml. Because activation performs editable install with --no-deps, this mismatch is not corrected automatically, so fresh environments can run Bloom against an older zebra-day than the declared requirement, which risks runtime incompatibilities.
Useful? React with 👍 / 👎.
1 participant
What changed
bloom_env.yamlto repo-rootenvironment.yamlactivate,README.md, andpyproject.tomlto point atsource ./activate <deploy-name>as the canonical entry pathbloom_env.yamlandrequirements.txtfilesdocs/remove_siblings.mdWhy
The repo was in the middle of moving to deployment-scoped activation through
source ./activate <deploy-name>, but parts of the docs and tool metadata still referenced the old environment files. This change makes the environment contract internally consistent.Validation
source ./activate local && pytest --no-cov tests/test_deploy_contract.py -qsource ./activate local && pytest tests/test_deploy_contract.py -qexercises the test successfully, but the repo-wide coverage gate fails when run as a one-file slice