Draft
Conversation
Capitalization Co-authored-by: Graham Christensen <graham@grahamc.com>
…b49-c3c7-4c4a-8a57-885b2760b0b8 Release v3.17.0
We now ensure that there are never any null pointers in instancesPre.
Fix crash in `nix repl` loading an invalid WASM file twice
Substitution is generally faster. However, in case the underlying fetcher already has the input locally (e.g. in the tarball/Git cache, or if it's a local Git repo), we don't want to substitute. So InputScheme::getAccessor() now has a `fastOnly` argument to return an accessor only if it doesn't involve any slow, remote fetching. So Input::getAccessor() now does the following: 1. InputScheme::getAccessor(fastOnly=true) 2. Try substitution 3. InputScheme::getAccessor(fastOnly=false)
This makes `nix flake check` skip `legacyPackages` again.
"Ignored" suggests that the command would succeed if it wasn't for the error that finishAll() propagates, but that's not the case.
…restore-substitution-before-fetching Input::getAccessor(): Try substitution before fetching
This wasn't handling Interrupted, since it's a subclass of BaseError, not Error. Since this is called from handleExceptions() while printing exceptions, the uncaught exception here was causing Nix to crash with a call to std::unexpected().
This hardens Nix against uncaught exceptions (like Interrupted) while printing exceptions.
…etion nix profile upgrade/remove: Implement tab completion
…detsys-nix-crashes-on-sigint-with-internal-error Don't crash if SIGINT happens while printing an exception
nix-env -i: Wait for the async path writer
…nix-flake-check-fix-legacypackages-handling Add `isLegacy` flake schema output attribute
These are name/value pairs from the build host that can be configured through the `build-provenance-tags` setting.
Add tags to BuildProvenance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Not intended to be merged directly. This PR is a convenience to show the diff between upstream Nix and Determinate Nix (the
mainbranch).Continuation of #4.