Open
Conversation
Marking these as specific dependencies for the dev environment.
Forgot to update this flag, as it's not ESM, quite yet at least. Will look into that once everything is type-checked.
Owner
|
Thanks for the contribution! Though I can't accept this PR yet because the tsconfig.json file is missing from the actual codebase, and there are duplicate method definitions. Additionally, the buffer type annotations are incorrect. Please fix these issues! |
DeveloperExotic
force-pushed
the
main
branch
3 times, most recently
from
26a925d to
2be0b85
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Started setting up the initial stages of adding type checking to the project. Right now it is with JSDoc type annotations, and a tsconfig which allows type checking in the editor, as well as the terminal. There are more files to be annotated, thought I would upstream this as a starting basis.
Thanks for building this project! Love that it uses Node.js as well, a great way to incrementally build it.