fix(dgw): reduce log noise for missing recording storage disk#1728
Merged
Benoît Cortier (CBenoit) merged 1 commit intomasterfrom Mar 27, 2026
Merged
fix(dgw): reduce log noise for missing recording storage disk#1728Benoît Cortier (CBenoit) merged 1 commit intomasterfrom
Benoît Cortier (CBenoit) merged 1 commit intomasterfrom
Conversation
When the recording storage disk cannot be found during a heartbeat or preflight check, only the first occurrence is now logged at WARN. Subsequent repeated occurrences are downgraded to DEBUG until the disk becomes available again, at which point the condition can surface at WARN once more. The recording path is included in the log event for context. Issue: DGW-353
Marc-André Moreau (awakecoding)
approved these changes
Mar 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Reduces WARN-level log noise when the recording storage disk cannot be resolved during periodic health checks, while preserving visibility of the initial fault and re-surfacing it after recovery (DGW-353).
Changes:
- Add a small state machine (
NoDiskState) to log the first “disk missing” occurrence at WARN and subsequent repeats at DEBUG until recovery. - Include
recording_pathas structured log context for the “disk missing” event. - Add unit tests validating first-occurrence vs repeated-occurrence behavior and recovery re-WARN behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Marc-André Moreau (mamoreau-devolutions)
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the recording storage disk cannot be found during a heartbeat or preflight check, only the first occurrence is now logged at WARN. Subsequent repeated occurrences are downgraded to DEBUG until the disk becomes available again, at which point the condition can surface at WARN once more. The recording path is included in the log event for context.
Issue: DGW-353