Draft
Conversation
KarlLevik
requested changes
Aug 11, 2022
Member
KarlLevik
left a comment
KarlLevik
left a comment
There was a problem hiding this comment.
Could do with a table comment explaining what the table is for.
Also, there is no json_validate check on the definition column.
Contributor
Author
|
Should i move |
stufisher
force-pushed
the
detector_rois
branch
from
83e95bb to
2cb4801
Compare
stufisher
force-pushed
the
detector_rois
branch
from
2cb4801 to
72c9135
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows the ROIs from a 2d detector to be specified in the database for downstream processing. I am open to discussion on this one. The idea is that the definition of the ROI is defined in json to support arbitrary types. This ROI can then be linked to an output
XRFFluorescenceMapping(nothing to do with XRF but the table structure is consistent for any type ofmapping) for traceability.Is something like this useful to you @jacobfilik?