Add DirectSR (D3D12) super resolution implementation#780
Open
MikhailGorobets wants to merge 14 commits intoDiligentGraphics:super_resolution2from
Open
Add DirectSR (D3D12) super resolution implementation#780MikhailGorobets wants to merge 14 commits intoDiligentGraphics:super_resolution2from
MikhailGorobets wants to merge 14 commits intoDiligentGraphics:super_resolution2from
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
TheMostDiligent
force-pushed
the
super_resolution2
branch
from
1764aac to
9c44db2
Compare
TheMostDiligent
requested changes
Mar 15, 2026
MikhailGorobets
force-pushed
the
super_resolution2
branch
20 times, most recently
from
fb1e941 to
a22addd
Compare
…D12), MetalFX (Metal)
MikhailGorobets
force-pushed
the
super_resolution2
branch
from
a22addd to
7c37696
Compare
TheMostDiligent
force-pushed
the
super_resolution2
branch
from
e6c13cf to
18b5abb
Compare
MikhailGorobets
force-pushed
the
super_resolution2
branch
from
7c37696 to
e6b65d1
Compare
MikhailGorobets
force-pushed
the
super_resolution2
branch
from
e6b65d1 to
8242d2a
Compare
MikhailGorobets
force-pushed
the
super_resolution2
branch
4 times, most recently
from
fc100d8 to
fdb72d1
Compare
MikhailGorobets
force-pushed
the
super_resolution2
branch
2 times, most recently
from
bf9b09d to
9357d92
Compare
Comment on lines
+333
to
+335
| // Global toggles: | ||
| // #define FFX_HALF (1) | ||
| // #define FFX_HLSL_SM (62) |
Check notice
Code scanning / CodeQL
Commented-out code Note
Comment on lines
+363
to
+371
| /* | ||
| #define FFX_MIN16_SCALAR( TypeName, BaseComponentType ) typedef BaseComponentType TypeName; | ||
| #define FFX_MIN16_VECTOR( TypeName, BaseComponentType, COL ) typedef vector<BaseComponentType, COL> TypeName; | ||
| #define FFX_MIN16_MATRIX( TypeName, BaseComponentType, ROW, COL ) typedef matrix<BaseComponentType, ROW, COL> TypeName; | ||
| #define FFX_16BIT_SCALAR( TypeName, BaseComponentType ) typedef BaseComponentType TypeName; | ||
| #define FFX_16BIT_VECTOR( TypeName, BaseComponentType, COL ) typedef vector<BaseComponentType, COL> TypeName; | ||
| #define FFX_16BIT_MATRIX( TypeName, BaseComponentType, ROW, COL ) typedef matrix<BaseComponentType, ROW, COL> TypeName; | ||
| */ |
Check notice
Code scanning / CodeQL
Commented-out code Note
Comment on lines
+410
to
+441
| /* | ||
| FFX_MIN16_SCALAR( FFX_MIN16_F , float ); | ||
| FFX_MIN16_VECTOR( FFX_MIN16_F2, float, 2 ); | ||
| FFX_MIN16_VECTOR( FFX_MIN16_F3, float, 3 ); | ||
| FFX_MIN16_VECTOR( FFX_MIN16_F4, float, 4 ); | ||
| FFX_MIN16_SCALAR( FFX_MIN16_I, int ); | ||
| FFX_MIN16_VECTOR( FFX_MIN16_I2, int, 2 ); | ||
| FFX_MIN16_VECTOR( FFX_MIN16_I3, int, 3 ); | ||
| FFX_MIN16_VECTOR( FFX_MIN16_I4, int, 4 ); | ||
| FFX_MIN16_SCALAR( FFX_MIN16_U, uint ); | ||
| FFX_MIN16_VECTOR( FFX_MIN16_U2, uint, 2 ); | ||
| FFX_MIN16_VECTOR( FFX_MIN16_U3, uint, 3 ); | ||
| FFX_MIN16_VECTOR( FFX_MIN16_U4, uint, 4 ); | ||
| FFX_16BIT_SCALAR( FFX_F16_t , float ); | ||
| FFX_16BIT_VECTOR( FFX_F16_t2, float, 2 ); | ||
| FFX_16BIT_VECTOR( FFX_F16_t3, float, 3 ); | ||
| FFX_16BIT_VECTOR( FFX_F16_t4, float, 4 ); | ||
| FFX_16BIT_SCALAR( FFX_I16_t, int ); | ||
| FFX_16BIT_VECTOR( FFX_I16_t2, int, 2 ); | ||
| FFX_16BIT_VECTOR( FFX_I16_t3, int, 3 ); | ||
| FFX_16BIT_VECTOR( FFX_I16_t4, int, 4 ); | ||
| FFX_16BIT_SCALAR( FFX_U16_t, uint ); | ||
| FFX_16BIT_VECTOR( FFX_U16_t2, uint, 2 ); | ||
| FFX_16BIT_VECTOR( FFX_U16_t3, uint, 3 ); | ||
| FFX_16BIT_VECTOR( FFX_U16_t4, uint, 4 ); | ||
| */ |
Check notice
Code scanning / CodeQL
Commented-out code Note
| #include "../shaders/fsr1/ffx_fsr1.h" | ||
| #undef FFX_CPU | ||
|
|
||
| #include "../shaders/FSRStructures.fxh" |
Check notice
Code scanning / CodeQL
Include header files only Note
|
|
||
| const bool SharpeningEnabled = (m_Desc.Flags & SUPER_RESOLUTION_FLAG_ENABLE_SHARPENING) != 0; | ||
|
|
||
| if (SharpeningEnabled && m_LastSharpness != Attribs.Sharpness) |
Check notice
Code scanning / CodeQL
Equality test on floating-point values Note
| Settings = {}; | ||
| if (const ProviderInfo* pEntry = FindProvider(Attribs.VariantId)) | ||
| Settings = {}; | ||
| const auto [pEntry, pInfo] = FindProvider(Attribs.VariantId); |
Check notice
Code scanning / CodeQL
Unused local variable Note
MikhailGorobets
force-pushed
the
super_resolution2
branch
from
9357d92 to
7515cc0
Compare
TheMostDiligent
force-pushed
the
super_resolution2
branch
from
8fc4f96 to
a19144b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.