Bump minimum PHP version to 8.3 and update package dependencies#1569
Merged
cpeel merged 9 commits intoDistributedProofreaders:masterfrom Mar 29, 2026
Merged
Bump minimum PHP version to 8.3 and update package dependencies#1569cpeel merged 9 commits intoDistributedProofreaders:masterfrom
cpeel merged 9 commits intoDistributedProofreaders:masterfrom
Conversation
voku/portable-utf8 has commits to fix the deprecation warnings for PHP 8.4, but only in the dev-master branch, not a released version. The package is pseudo-abandoned and this is a stop-gap until the dev comes back, hands it off to someone else, or someone forks it.
Fix two deprecation warnings.
cpeel
requested review from
70ray,
chrismiceli,
jchaffraix,
srjfoo and
windymilla
chrismiceli
approved these changes
Mar 25, 2026
srjfoo
approved these changes
Mar 25, 2026
Member
srjfoo
left a comment
srjfoo
left a comment
There was a problem hiding this comment.
I tried to do a reasonably thorough test of Markdown in PCs (following the instructions in our wiki page). See this project.
windymilla
approved these changes
Mar 25, 2026
Collaborator
windymilla
left a comment
windymilla
left a comment
There was a problem hiding this comment.
Code looks good based on my limited understanding.
WordCheck appeared to work successfully.
RFM AV scan worked:
Status of file upload to folder ~uploads/Users/windymilla
File successfully uploaded
Checksum validated
Starting virus check
No infection found
File ukrainianfolk.zip successfully uploaded to folder ~uploads/Users/windymilla.
jchaffraix
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does 4 main things in separate commits:
portable-utf8. The developer has gone a bit MIA and fixed the deprecation warnings in the code but didn't cut a new release. This will eventually be problematic for us and others.All of these are in a single PR to reduce the testing effort. In broad strokes we should ensure:
The unit tests will cover phpstan, phpunit, and other related dev-focused updates. Our WordCheck unit tests should do a good job of validating the portable-utf8 changes as well.
The only testing gap is phpmailer which I'm not too worried about but is challenging to test on TEST.
Sandbox: https://www.pgdp.org/~cpeel/c.branch/test-php-version-bump/