Conversation
- Make Material class abstract and reorganize properties - Add ShaderMaterial, PhongMaterial, BlinnMaterial, PbrMaterial types - Introduce FbxMaterialBuilder hierarchy for material parsing - FBX builder now dispatches by ShadingModel for materials - Property lookup is now case-insensitive and type-safe - Add MultiLayer and ShadingModel FBX tokens - Expand test suite with local FBX sample cases - Remove obsolete Geometry property class and clean up code
Moved all material and texture classes from MeshIO.Shaders to a new MeshIO.Materials namespace. Introduced a Texture class with filter and wrap enums, and extended PbrMaterial to support texture properties. Added GltfTextureBuilder and GltfConverter for glTF texture handling. Updated GltfMaterialBuilder to assign textures, and rewrote GltfMaterialNormalTextureInfo to implement IGltfTextureInfo. GlbFileBuilder now manages images, samplers, and textures. Renamed Camera.OrtographicZoom to OrthographicZoom. Updated all references and usages to reflect these changes.
- Add XML docs and DiffuseFactor to Material; remove unused properties - Improve FbxMaterialBuilder property extraction and naming - Move TextureFilterType and WrapMode enums to separate files - Update Texture class to use new enums and clarify property order - Clean up GltfMaterialBuilder: remove unused method, minor logic changes
Update GltfTextureInfo and GltfMaterialOcclusionTextureInfo to use string-based Index properties and implement IGltfTextureInfo. Remove Scale from IGltfTextureInfo. Fix GltfMaterialBuilder to use correct texture property. Add summary comment to PbrMaterial. These changes improve flexibility and code clarity for texture referencing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
First approach for materials.