changed "as.vector" to appease R#25
Open
ryandward wants to merge 7 commits intoDoseResponse:masterfrom
Open
Conversation
explicitly state how to install this version of the package
|
Thanks @ryandward for pointing out this issue and suggesting the code changes. Considering this PR, this issue was resolved in the re-factored drc package. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the error where R complains about using deprecated array recycling. It also speeds up the calculation speed from ~2-3 minutes to a few seconds on a relatively small dataset.
See this issue: #17