Add "ignore TMEM" flag to mksprite#854
Open
SpookyIluha wants to merge 1 commit intoDragonMinded:unstablefrom
Open
Add "ignore TMEM" flag to mksprite#854SpookyIluha wants to merge 1 commit intoDragonMinded:unstablefrom
SpookyIluha wants to merge 1 commit intoDragonMinded:unstablefrom
Conversation
Collaborator
|
As discussed on Discord, mksprite is a bit confused right now between the "texture" codepath (must fit TMEM) and the "sprite" codepath (no limits). I think it would be better to be explicit here and start asking the user to specify which behavior is expected. Most of mksprite currently assumes "sprite" rather than "texture" (mipmaps being the egregious exception) so I'd rather reverse the flag compared to this PR. So I would suggest something like:
or whatever else. I don't like much any of the above, maybe the first is the clearest after all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mainly to allow mipmaps for large sprites.
With this flag, no TMEM checks are performed during to .sprite conversion