Enable smaller inter-particle distance values#251
Open
kmarchais wants to merge 1 commit intoDualSPHysics:developfrom
Open
Enable smaller inter-particle distance values#251kmarchais wants to merge 1 commit intoDualSPHysics:developfrom
kmarchais wants to merge 1 commit intoDualSPHysics:developfrom
Conversation
Allow input of smaller inter-particle distance values by increasing the number of decimal digits in the size input and dock dp widgets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem Solved
Previously, users could not set inter-particle distance values lower than 0.001. This change allows for much smaller values by increasing the number of decimal places displayed and accepted in the input field.
Changes
mod/widgets/custom_widgets/size_input.py: Added decimals parameter to SizeInput constructormod/widgets/dock/dock_dp_widget.py: Set dp_input to use 6 decimal placesAlternative Solution
Another approach would be to modify the DEFAULT_DECIMALS constant, but this would affect all other numeric inputs throughout the application. The current solution provides targeted precision only where needed.