Skip to content

Update config with new drawing + new noise#3

Merged
arunkannawadi merged 3 commits intomainfrom
update_config
Feb 26, 2026
Merged

Update config with new drawing + new noise#3
arunkannawadi merged 3 commits intomainfrom
update_config

Conversation

@aguinot
Copy link
Copy Markdown
Collaborator

@aguinot aguinot commented Feb 16, 2026

Update the config to reflect the changes in roman_imsim for the drawing method and the new noise builder

arunkannawadi
arunkannawadi approved these changes Feb 16, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@arunkannawadi arunkannawadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! To be merged right after the corresponding change in roman_imsim.

Comment thread hack.yaml
@aguinot
Copy link
Copy Markdown
Collaborator Author

aguinot commented Feb 16, 2026 •
edited
Loading

@arunkannawadi Should I merge?
I don't remember the rules if I can merge or if should expect you to do it?

@arunkannawadi
Copy link
Copy Markdown
Member

arunkannawadi commented Feb 17, 2026

Normally, if you have a PR that is approved, you can merge them yourself. But because there are too many competing PRs happening this week, may be I should merge them?

@aguinot
Copy link
Copy Markdown
Collaborator Author

aguinot commented Feb 18, 2026

Updated to account for latest changes

@aguinot
Copy link
Copy Markdown
Collaborator Author

aguinot commented Feb 25, 2026

@arunkannawadi @sidneymau
Do we need further changes to this PR before merge? It will require PR #66 from roman_imsim for this to work

@arunkannawadi
Copy link
Copy Markdown
Member

arunkannawadi commented Feb 25, 2026

Probably not, but hang on. The end-to-end test isn't working due to a caching bug.

@arunkannawadi
Copy link
Copy Markdown
Member

arunkannawadi commented Feb 25, 2026

OK, may be not a bug, but I am worried that caching was fetching older versions of the code/data instead of the latest one. In any case, this is staged after the template one, which is ready to be merged after a review.

aguinot and others added 3 commits February 25, 2026 21:22
@aguinot @arunkannawadi
Update config with new drawing + new noise
1d27915
@aguinot @arunkannawadi
Change noise type to NoNoise and comment defaults
9ac1942 
Updated noise settings to use 'NoNoise' instead of 'RomanNoise' and commented out default noise options.
@aguinot @arunkannawadi
Add mjd to RomanNoise builder
b1dba1f
@arunkannawadi arunkannawadi merged commit f8e5b10 into main Feb 26, 2026
@arunkannawadi arunkannawadi deleted the update_config branch February 26, 2026 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sidneymau sidneymau sidneymau left review comments

@arunkannawadi arunkannawadi arunkannawadi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aguinot @arunkannawadi @sidneymau