Add initial repo-local Codex skills#144
Add initial repo-local Codex skills#144tomvothecoder wants to merge 1 commit intoE3SM-Project:mainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d954e9fd63
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| ## Purpose | ||
|
|
||
| Implement SimBoard frontend behavior and UI in code. Work inside the existing React 19 + TypeScript + Vite app without introducing new architectural patterns unless the repo already uses them in the touched area. |
There was a problem hiding this comment.
This skill text hardcodes a dependency version (React 19) in an instruction file, which violates the repo’s anti-drift policy in AGENTS.md that instruction files should not pin volatile version values. Once React is upgraded, this guidance becomes stale and can misdirect future AI-generated changes, so the version-specific wording should be replaced with a version-agnostic description (for example, “existing React + TypeScript + Vite app”).
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Pull request overview
Adds a first set of repo-local agent “skills” under .agents/skills/, intended to guide role-scoped work (review, planning, docs, testing, UX, frontend, backend) using SimBoard’s actual monorepo conventions.
Changes:
- Introduces new SKILL definitions for
backend-engineer,frontend-engineer,reviewer,test-engineer,docs-writer,feature-planner, andui-ux-designer. - Aligns skill outputs/inputs and constraints with SimBoard’s make/uv/pnpm workflows and feature-boundary architecture.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
.agents/skills/ui-ux-designer/SKILL.md |
Defines UX-focused guidance and constraints for SimBoard flows and UI vocabulary. |
.agents/skills/test-engineer/SKILL.md |
Defines testing responsibilities aligned to pytest + existing repo commands and constraints. |
.agents/skills/reviewer/SKILL.md |
Defines review expectations and repo-specific checks for backend/frontend changes. |
.agents/skills/frontend-engineer/SKILL.md |
Defines frontend implementation guidance aligned to current React/Vite/Tailwind structure. |
.agents/skills/feature-planner/SKILL.md |
Defines how to turn requests into repo-specific, PR-sized execution plans. |
.agents/skills/docs-writer/SKILL.md |
Defines documentation guidance aligned to anti-drift policy and repo doc locations. |
.agents/skills/backend-engineer/SKILL.md |
Defines backend implementation guidance aligned to FastAPI/SQLAlchemy/Alembic conventions. |
|
|
||
| ## Purpose | ||
|
|
||
| Implement SimBoard frontend behavior and UI in code. Work inside the existing React 19 + TypeScript + Vite app without introducing new architectural patterns unless the repo already uses them in the touched area. |
There was a problem hiding this comment.
AGENTS.md anti-drift policy prohibits hardcoding dependency versions in instruction files; “React 19” is version-specific. Remove the version number (or reference frontend/package.json as the source of truth).
| Implement SimBoard frontend behavior and UI in code. Work inside the existing React 19 + TypeScript + Vite app without introducing new architectural patterns unless the repo already uses them in the touched area. | |
| Implement SimBoard frontend behavior and UI in code. Work inside the existing React + TypeScript + Vite app (with exact versions defined in `frontend/package.json`) without introducing new architectural patterns unless the repo already uses them in the touched area. |
| - Treat `AGENTS.md` in the repo root as authoritative for repo behavior. | ||
| - Backend work should stay inside `backend/app/features/*`, `backend/app/common/*`, `backend/app/core/*`, and related tests under `backend/tests/*`. | ||
| - New backend routers belong in feature modules and must be registered in `backend/app/main.py`. | ||
| - Backend request/response schemas use `CamelInBaseModel` and `CamelOutBaseModel`; review API contract drift carefully because the frontend expects camelCase payloads. | ||
| - Backend writes commonly use the sync SQLAlchemy session plus `transaction(db)` from `backend/app/core/database.py`. | ||
| - Frontend work must respect `frontend/eslint.config.js` architectural boundaries. |
There was a problem hiding this comment.
The statement “Backend work should stay inside backend/app/features/*, backend/app/common/*, backend/app/core/* …” is inconsistent with the repo layout: core routers live in backend/app/api/* and models are under backend/app/models/*. Broaden this guidance (e.g., backend/app/** plus backend/migrations/** and backend/tests/**) so it matches the actual structure.
Summary
Validation