Bug fix: conditional logic for wood_rwc calculation#431
Merged
xiangtaoxu merged 1 commit intomasterfrom Mar 12, 2026
Merged
Conversation
I found this bug whilst looking for some code that could cause the crash in issue #430. The `if` block had no `else` clause, which could leave the variable undefined. The proposed fix follows the same logic for calculating `leaf_rwc` in the same sub-routine . Fixing this bug does not solve the problem in issue #430 according to @sdeherto, but this is still needs correction.
xiangtaoxu
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I found this bug whilst looking for some code that could cause the crash in issue #430. The
ifblock had noelseclause, which could leave the variable undefined. The proposed fix follows the same logic for calculatingleaf_rwcin the same sub-routine .Fixing this bug does not solve the problem in issue #430 according to @sdeherto, but this is still needs correction.
Collaborators
Types of changes
Changes in Settings, Input Files or Output Files
Expectation of Answer Changes:
This would change the results in edge cases when running ED2 with plant hydraulics.
Checklist:
Testing :