Merged
Conversation
- Back up `app.cfg` before testing, restore after - Copy `test_app.cfg` once, on test start
- Add comments to test_run_cmd - Add comments and test cases to test_run_subprocess
sondrebr
commented
Feb 10, 2026
|
|
||
|
|
||
| class MockCommand(): | ||
| def __init__(self, command, general_args=[], action_filters=MockActionFilter(), build_params=None): |
trz42
requested changes
Mar 9, 2026
Co-authored-by: Thomas Röblitz <trz42@users.noreply.github.com>
trz42
approved these changes
Mar 17, 2026
Contributor
trz42
left a comment
trz42
left a comment
There was a problem hiding this comment.
Well done! Thanks a lot for the changes.
Contributor
|
+1, thanks a lot for all this effort @sondrebr! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves the way tests are handled, and adds a number of tests to improve test coverage.
The
tests/folder is excluded from the coverage report to give a more accurate overview. Also,app.cfgis backed up before running the tests to avoid accidentally overwriting it when running the tests locally.As for the tests themselves, I've focused on the files in
tools/.Adding this as a draft while I work on a few more tests. If you have any opinions on the style for the tests, I would love to hear them - especially regarding the usage of the
pytest.mark.parametrizedecorator vs. putting everything in the function definition.