Only include files modified by the PR in tarball#1119
Merged
boegel merged 6 commits intoEESSI:2023.06-software.eessi.iofrom Jun 11, 2025
Merged
Only include files modified by the PR in tarball#1119boegel merged 6 commits intoEESSI:2023.06-software.eessi.iofrom
boegel merged 6 commits intoEESSI:2023.06-software.eessi.iofrom
Conversation
|
Instance
|
Member
Author
|
bot: build repo:eessi.io-2023.06-software instance:eessi-bot-mc-aws arch:x86_64/amd/zen2 |
Updates by the bot instance
|
|
New job on instance
|
Member
Author
|
bot: build repo:eessi.io-2023.06-software instance:eessi-bot-mc-aws arch:x86_64/amd/zen2 |
|
This also was not triggered in this case: New job on instance
|
Member
Author
|
bot: build repo:eessi.io-2023.06-software instance:eessi-bot-mc-aws arch:x86_64/amd/zen2 |
|
This seems to work as expected, in the Slurm logs I see: New job on instance
|
Member
Author
|
NOTE This PR does not need to be deployed |
boegel
requested changes
Jun 11, 2025
| } | ||
|
|
||
| file_changed_in_pr() { | ||
| local full_path="$1" |
Contributor
There was a problem hiding this comment.
We should also check that full_path is not empty?
Member
Author
There was a problem hiding this comment.
Isn't that kind of done at line 16?
Contributor
There was a problem hiding this comment.
test -f (without argument) exits with zero, so I'd say no
Contributor
There was a problem hiding this comment.
Interestingly, test -f "" does fail with non-zero exit code, so it's fine as is I guess, don't want to nitpick here...
Member
Author
There was a problem hiding this comment.
You had me sweating but
ocaisa@~$ export full_path="$PWD/file"; [[ -f "$full_path" ]] || echo Fail
Fail
ocaisa@~$ touch file
ocaisa@~$ export full_path="$PWD/file"; [[ -f "$full_path" ]] || echo Fail
ocaisa@~$ export full_path=""; [[ -f "$full_path" ]] || echo Fail
Fail
ocaisa@~$ export full_path= ; [[ -f "$full_path" ]] || echo Fail
Fail
ocaisa@~$ unset full_path
ocaisa@~$ [[ -f "$full_path" ]] || echo Fail
Fail
so the check below is indeed enough
Co-authored-by: Kenneth Hoste <kenneth.hoste@ugent.be>
Contributor
|
One more test run to rule out utter breakage (I'm aware no deploy is needed here): bot: build repo:eessi.io-2023.06-software instance:eessi-bot-mc-aws arch:x86_64/amd/zen2 |
|
New job on instance
|
boegel
approved these changes
Jun 11, 2025
Contributor
boegel
left a comment
boegel
left a comment
There was a problem hiding this comment.
looks fine, if there's any fallout we'll deal with it in a follow-up PR
boegel
merged commit 5ca8e88
into
EESSI:2023.06-software.eessi.io
68 of 81 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.