Skip to content

ctsm5.4.033: Update FATES tag with fix for LUH no_nan data set issue #3926

Open
glemieux wants to merge 6 commits intoESCOMP:masterfrom
glemieux:fates-luh-isnan-fix
Open

ctsm5.4.033: Update FATES tag with fix for LUH no_nan data set issue #3926
glemieux wants to merge 6 commits intoESCOMP:masterfrom
glemieux:fates-luh-isnan-fix

Conversation

@glemieux
Copy link
Copy Markdown
Contributor

Description of changes

Resolves #3789

Specific notes

Contributors other than yourself, if any: @samsrabin

CTSM Issues Fixed (include github issue #):

Are answers expected to change (and if so in what way)?

Any User Interface Changes (namelist or namelist defaults changes)?

Does this create a need to change or add documentation? Did you do so?

Testing performed, if any:
(List what testing you did to show your changes worked as expected)
(This can be manual testing or running of the different test suites)
(Documentation on system testing is here: https://github.com/ESCOMP/ctsm/wiki/System-Testing-Guide)
(aux_clm on derecho for intel/gnu and izumi for intel/gnu/nag/nvhpc is the standard for tags on master)

NOTE: Be sure to check your coding style against the standard
(https://github.com/ESCOMP/ctsm/wiki/CTSM-coding-guidelines) and review
the list of common problems to watch out for
(https://github.com/ESCOMP/CTSM/wiki/List-of-common-problems).

If this PR changes the CTSM web documentation, please see our contribution guidelines for documentation.

@glemieux glemieux moved this to In progress - master in CTSM: Upcoming tags Apr 13, 2026
@glemieux
Copy link
Copy Markdown
Contributor Author

Currently waiting on FATES-side approval and tag creation.

@glemieux glemieux moved this from Finding Reviewers to Under Review in FATES Pull Request Planning and Status Apr 16, 2026
@glemieux glemieux moved this from Under Review to Final Testing in FATES Pull Request Planning and Status Apr 16, 2026
@wwieder wwieder requested a review from adrifoster April 16, 2026 16:06
@ekluzek ekluzek added this to the FATES Freeze for ctsm6 milestone Apr 16, 2026
@glemieux
Copy link
Copy Markdown
Contributor Author

Regression testing on izumi against ctsm5.4.032 is complete. All expected tests pass B4B, with the known exception of the FATES tests. Those DIFFs are consistent with those seen in NGEET/fates#1522 (i.e. sci.1.92.0_api.44.1.0).

Results: /scratch/cluster/glemieux/ctsm-tests/tests_0416-113720iz

New baseline ctsm5.4.033 on izumi has had permissions updated to be readable by group and others.

Still waiting on the derecho tests to get through the queue.

@glemieux
Copy link
Copy Markdown
Contributor Author

Regression testing on derecho against ctsm5.032 is complete. All expected tests are B4B, with the known exceptions for the fates testmods (as discussed above). The fatessp tests show DIFFs consistent with NGEET/fates#1522 (comment).

The only unexpected DIFF was for NLCOMP with both compiler versions of SMS_D_Ld5.5x5_amazon_rHDMA.I2000Clm60SpMizGs.derecho_intel.mizuroute-default. The Teststatus.log is showing something about "Inequivalent lines". Has anyone seen this before? Can it safely be ignored?

Results: /glade/u/home/glemieux/scratch/ctsm-tests/tests_0416-090144de

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In progress - master

Development

Successfully merging this pull request may close these issues.

FatesColdLUH2 tests fail with input files that have non-NaN fills

2 participants