Skip to content

rimport: Add --check functionality#18

Merged
samsrabin merged 13 commits intoESMCI:mainfrom
samsrabin:add-rimport-check
Feb 4, 2026
Merged

rimport: Add --check functionality#18
samsrabin merged 13 commits intoESMCI:mainfrom
samsrabin:add-rimport-check

Conversation

@samsrabin
Copy link
Contributor

New rimport option --check checks whether file has been published but does not attempt copy.

Resolves #2.

Other changes:

  • Always print whether a file can be downloaded from the server.
  • If file exists in staging directory but hasn't been linked, print a message with instructions for doing so. (In my next PR, this will be replaced with an actual call of relink.)
  • Prints file path and indents messages; useful for tracking messages when rimporting a list of files.

@samsrabin samsrabin requested a review from jedwards4b February 4, 2026 17:32
@samsrabin samsrabin self-assigned this Feb 4, 2026
@samsrabin samsrabin added the enhancement New feature or request label Feb 4, 2026
Copy link
Contributor

@jedwards4b jedwards4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@samsrabin samsrabin merged commit 891c990 into ESMCI:main Feb 4, 2026
4 checks passed
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 96.19048% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.76%. Comparing base (ff55606) to head (92cf1a4).
⚠️ Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
rimport 89.13% 5 Missing ⚠️
tests/rimport/test_can_file_be_downloaded.py 90.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main      #18    +/-   ##
========================================
  Coverage   97.76%   97.76%            
========================================
  Files          21       22     +1     
  Lines        2010     2195   +185     
========================================
+ Hits         1965     2146   +181     
- Misses         45       49     +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Need some way to be able to verify files reside in the GDEX

3 participants