Merged
Conversation
For consistency with relink.
Changes behavior to hide inputdata_root help text.
To match relink behavior.
Contributor
|
Need to fix the testing before it's ready to merge. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
==========================================
+ Coverage 97.76% 99.12% +1.36%
==========================================
Files 21 27 +6
Lines 2010 2746 +736
==========================================
+ Hits 1965 2722 +757
+ Misses 45 24 -21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work to prepare for addressing #14. Only one behavior should be changed:
rimport --helpno longer mentions-inputdata. This makes it consistent withrelink.py.Some new behaviors:
rimportcan now accept both--fileand--filelist, as well as (likerelink.py) positional arguments.relink.pynow prints filename and indents other messages likerimportdoes.inputdataoption flags between scripts.relink.pynow accepts-helpflag likerimportalready does.rimportnow uses Python'sloggingmodule and accepts--quiet/--verboseoptions likerelink.pydoes. (Currently--verbosewill print no additional messages, but the capability is there and tested.)