Skip to content

Harmonize rimport and relink#19

Merged
samsrabin merged 32 commits intoESMCI:mainfrom
samsrabin:harmonize-rimport-relink
Feb 6, 2026
Merged

Harmonize rimport and relink#19
samsrabin merged 32 commits intoESMCI:mainfrom
samsrabin:harmonize-rimport-relink

Conversation

@samsrabin
Copy link
Contributor

Work to prepare for addressing #14. Only one behavior should be changed: rimport --help no longer mentions -inputdata. This makes it consistent with relink.py.

Some new behaviors:

  • rimport can now accept both --file and --filelist, as well as (like relink.py) positional arguments.
  • relink.py now prints filename and indents other messages like rimport does.
  • Unified inputdata option flags between scripts.
  • relink.py now accepts -help flag like rimport already does.
  • rimport now uses Python's logging module and accepts --quiet/--verbose options like relink.py does. (Currently --verbose will print no additional messages, but the capability is there and tested.)

Changes behavior to hide inputdata_root help text.
@samsrabin samsrabin self-assigned this Feb 6, 2026
@samsrabin samsrabin added the enhancement New feature or request label Feb 6, 2026
@samsrabin samsrabin requested a review from jedwards4b February 6, 2026 21:14
Copy link
Contributor

@jedwards4b jedwards4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

@jedwards4b
Copy link
Contributor

Need to fix the testing before it's ready to merge.

@samsrabin samsrabin merged commit 7602cae into ESMCI:main Feb 6, 2026
4 checks passed
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 99.51807% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.12%. Comparing base (ff55606) to head (9843351).
⚠️ Report is 49 commits behind head on main.

Files with missing lines Patch % Lines
rimport 97.95% 1 Missing ⚠️
shared.py 97.82% 1 Missing ⚠️
tests/rimport/test_get_files_to_process.py 99.40% 1 Missing ⚠️
tests/rimport/test_main.py 99.46% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
+ Coverage   97.76%   99.12%   +1.36%     
==========================================
  Files          21       27       +6     
  Lines        2010     2746     +736     
==========================================
+ Hits         1965     2722     +757     
+ Misses         45       24      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants