Make Type field in Connection nullable to fix mismatch in JSON schema#372
Open
Goost91 wants to merge 1 commit intoEasyNetQ:masterfrom
Open
Make Type field in Connection nullable to fix mismatch in JSON schema#372Goost91 wants to merge 1 commit intoEasyNetQ:masterfrom
Goost91 wants to merge 1 commit intoEasyNetQ:masterfrom
Conversation
Goost91
requested review from
Pliner,
luigiberrettini,
micdenny and
zidad
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to changes in RabbitMQ 4.1 the Type field in Connection has seemingly become optional.
This caused the GetConnectionsAsync method to throw an exception.
I've tested the fix on a private NuGet feed initially to make sure it works, and it has solved the issue I had with it.