Skip to content

Comments

Disable autocorrect by default in text inputs#5953

Merged
j0ntz merged 2 commits intodevelopfrom
jon/fix/disable-autocorrect
Feb 21, 2026
Merged

Disable autocorrect by default in text inputs#5953
j0ntz merged 2 commits intodevelopfrom
jon/fix/disable-autocorrect

Conversation

@j0ntz
Copy link
Contributor

@j0ntz j0ntz commented Feb 20, 2026

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

None

Description

Context

Asana: "Desktop: Search bar automatically accepts autocorrects" (P2). On macOS and iPad, search bars would automatically accept autocorrect suggestions without explicit user action (e.g., typing "omw" would trigger "On my way!").

Changes

  • Default autoCorrect to false in SimpleTextInput and FilledTextInput
  • Explicitly set autoCorrect={true} in LogsModal, SurveyModal, and SendFromFioRows to preserve autocorrect for free-form text composition

Autocorrect Status by Callsite

Autocorrect now DISABLED (was enabled before this PR):

Component Field
CategoryModal Transaction subcategory
DevTestScene Big text test field
DevTestScene Big number test field
DevTestScene Basic test field
DevTestScene Prefix test field
DevTestScene Numeric test field
DevTestScene Prefix/suffix test field
DevTestScene Prefix/suffix test field 2
DevTestScene Custom error test field
DevTestScene DeepLink test field
DevTestScene Crypto amount test field
DevTestScene Fiat amount test field
GiftCardPurchaseScene Gift card amount
ManageTokensScene Token search
PasswordReminderModal Password verification
RampBankFormScene Account nickname
RampBankFormScene Owner first name
RampBankFormScene Owner last name
RampBankFormScene Bank name
RampBankFormScene Account number
RampBankFormScene Routing number
RampCreateScene Fiat amount
RampCreateScene Crypto amount
WalletListModal Wallet search
WalletRestoreScene Wallet search

Autocorrect remains DISABLED (no change):

Component Field
AccountActions Password confirmation
AddressModal Wallet address
ChangeMiningFeeScene Custom fee value
CreateWalletAccountSetupScene EOS account name
CreateWalletEditNameScene Wallet name
CreateWalletImportScene Import key/seed phrase
CreateWalletSelectCryptoScene Crypto search
DefaultFiatSettingScene Fiat currency search
DomainListModal FIO domain search
EditTokenScene Contract address
EditTokenScene Currency code
EditTokenScene Display name
EditTokenScene Decimal places
FiatPluginEnterAmountScene Fiat amount input
FiatPluginEnterAmountScene Crypto amount input
FiatPluginEnterAmountScene Fiat amount (swapped)
FiatPluginEnterAmountScene Crypto amount (swapped)
FioCreateHandleScene FIO handle
GiftCardSearchModal Gift card brand search
GuiFormField Plugin form fields
ListModal List item search
MaybeCustomServersSetting Custom node URL
MaybeMoneroUserSettings Custom Monero server URL
OtpVerificationModal OTP code
PromotionSettingsScene Promotion/installer code
SearchFooter Generic scene search
SettingsScene Delete account verification
SpendingLimitsScene Spending limit amount
TransactionsExportScene Bitwave account ID
WalletListMenuActions Wallet rename

Autocorrect remains ENABLED (intentional):

Component Field Reason
LogsModal User message Free-form text benefits from autocorrect
SendFromFioRows FIO memo Free-form text benefits from autocorrect
SurveyModal "Other" text (first page) Free-form text benefits from autocorrect
SurveyModal "Other" text (second page) Free-form text benefits from autocorrect

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

@j0ntz j0ntz force-pushed the jon/fix/disable-autocorrect branch 5 times, most recently from 4689c0b to 589a87f Compare February 20, 2026 22:57
Copy link
Contributor

@swansontec swansontec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only tiny changes needed.

@j0ntz j0ntz force-pushed the jon/fix/disable-autocorrect branch from e932887 to 00c2957 Compare February 20, 2026 23:58
@j0ntz
Copy link
Contributor Author

j0ntz commented Feb 20, 2026

Both comments addressed: used cleaners for error matching and instanceof for safe message extraction.

Copy link
Contributor

@swansontec swansontec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, except the last commit. That one is wrong - we want to graduate files even if they have benign warnings.

@j0ntz j0ntz force-pushed the jon/fix/disable-autocorrect branch from 00c2957 to 4dda380 Compare February 21, 2026 01:54
Change SimpleTextInput and FilledTextInput to default autoCorrect to false
instead of true. This prevents automatic acceptance of autocorrect
suggestions when users interact with search bars and other text inputs.

LogsModal explicitly sets autoCorrect={true} to preserve autocorrect for
user message composition.
@j0ntz j0ntz force-pushed the jon/fix/disable-autocorrect branch from 4dda380 to 0275afd Compare February 21, 2026 01:59
@j0ntz j0ntz merged commit ee01601 into develop Feb 21, 2026
2 of 3 checks passed
@j0ntz j0ntz deleted the jon/fix/disable-autocorrect branch February 21, 2026 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants