fix(cli): fix Prompt.select clear when descriptions wrap#5979
Open
kingstarfly wants to merge 1 commit intoEffect-TS:mainfrom
Open
fix(cli): fix Prompt.select clear when descriptions wrap#5979kingstarfly wants to merge 1 commit intoEffect-TS:mainfrom
kingstarfly wants to merge 1 commit intoEffect-TS:mainfrom
Conversation
🦋 Changeset detectedLatest commit: fca11fb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5978
When using
Prompt.selectwith choices that have long descriptions, navigating between options causes duplicate prompt lines to appear instead of updating in place. This happens becausehandleCleardoesn't account for terminal line wrapping.Changes
handleClearinselect.tsto calculate actual rendered line lengthsstatetohandleClearto determine which choice has its description displayedprefix + title + description) instead of empty newlinesRoot Cause
The previous implementation used:
This assumes each choice takes exactly 1 terminal row. However:
prefix (2 chars) + title + descriptioncontent length > terminal width, the line wraps to multiple rowsThe fix calculates actual content length per choice to properly determine rows to erase.
Testing
Tested locally with long descriptions in a narrow terminal - navigation now updates cleanly without leaving artifacts.