Skip to content

sqlite-bun query prep fail in Effect, not defect #6044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tim-smart merged 1 commit into from
Feb 8, 2026
Merged

sqlite-bun query prep fail in Effect, not defect #6044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-sqlite-bun-query-prepare.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@effect/sql-sqlite-bun": patch
---

Wrap `db.query()` (prepare) errors in `SqlError` so they surface as catchable failures instead of defects.
12 changes: 6 additions & 6 deletions packages/sql-sqlite-bun/src/SqliteClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,10 +104,10 @@ export const make = (
) =>
Effect.withFiberRuntime<Array<any>, SqlError>((fiber) => {
const useSafeIntegers = Context.get(fiber.currentContext, Client.SafeIntegers)
const statement = db.query(sql)
// @ts-ignore bun-types missing safeIntegers method, fixed in https://github.com/oven-sh/bun/pull/26627
statement.safeIntegers(useSafeIntegers)
try {
const statement = db.query(sql)
// @ts-ignore bun-types missing safeIntegers method, fixed in https://github.com/oven-sh/bun/pull/26627
statement.safeIntegers(useSafeIntegers)
return Effect.succeed((statement.all(...(params as any)) ?? []) as Array<any>)
} catch (cause) {
return Effect.fail(new SqlError({ cause, message: "Failed to execute statement" }))
Expand All @@ -120,10 +120,10 @@ export const make = (
) =>
Effect.withFiberRuntime<Array<any>, SqlError>((fiber) => {
const useSafeIntegers = Context.get(fiber.currentContext, Client.SafeIntegers)
const statement = db.query(sql)
// @ts-ignore bun-types missing safeIntegers method, fixed in https://github.com/oven-sh/bun/pull/26627
statement.safeIntegers(useSafeIntegers)
try {
const statement = db.query(sql)
// @ts-ignore bun-types missing safeIntegers method, fixed in https://github.com/oven-sh/bun/pull/26627
statement.safeIntegers(useSafeIntegers)
return Effect.succeed((statement.values(...(params as any)) ?? []) as Array<any>)
} catch (cause) {
return Effect.fail(new SqlError({ cause, message: "Failed to execute statement" }))
Expand Down