Suppress ARIA popup attributes on Tooltip/Popup triggers with non-interactive roles#1115
Merged
ykelkar-eightfold merged 6 commits intoEightfoldAI:mainfrom Apr 7, 2026
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
ykelkar-eightfold
force-pushed
the
ykelkar/popup-a11y
branch
from
c11cdfb to
f34f876
Compare
ykelkar-eightfold
changed the title
kheinrich-eightfold
approved these changes
Apr 4, 2026
Contributor
kheinrich-eightfold
left a comment
kheinrich-eightfold
left a comment
There was a problem hiding this comment.
LGTM overall
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY:
Fix issue where ARIA attribute is not allowed in non-interactive roles on Popup/Tooltip trigger elements.
aria-haspopup,aria-expanded, andaria-controlsare now conditionally suppressed for triggers with non-interactive roles (img,group,presentation,none) and/or via the newsuppressTriggerAriaprop.GITHUB ISSUE (Open Source Contributors)
N/A
JIRA TASK (Eightfold Employees Only):
https://eightfoldai.atlassian.net/browse/ENG-174581
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN: