deps: upgrade protobuf to >=6.33 and grpcio to >=1.76#8884
Draft
deps: upgrade protobuf to >=6.33 and grpcio to >=1.76#8884
Conversation
Update protobuf and grpcio dependencies to use floating version ranges, improving flexibility for downstream users. Dependency updates: - protobuf: ==6.32.1 -> >=6.33,<7 - grpcio: ==1.75.1 -> >=1.76 - grpcio-tools: ==1.75.1 -> >=1.76 Changes: - Update pyproject.toml, contrib/pyln-grpc-proto/pyproject.toml, and contrib/pyln-testing/pyproject.toml - Remove stale contrib/pyln-grpc-proto/uv.lock (referenced old protobuf3) - Regenerate protobuf files with grpcio-tools 1.76 - Remove manual protoc installation from CI setup.sh, now relies on grpcio-tools bundled protoc for version consistency Changelog-Changed: Upgraded protobuf to >=6.33 and grpcio to >=1.76 for better downstream compatibility
cdecker
force-pushed
the
upgrade-protobuf-grpcio
branch
from
a23b2f2 to
3bee784
Compare
Add a contrib/protoc wrapper script that invokes the protoc compiler bundled with grpcio-tools via 'uv run python3 -m grpc_tools.protoc'. This ensures the protoc version always matches the Python protobuf package version, avoiding runtime errors from version mismatches between generated code and the protobuf runtime library. The setup.sh script now installs this wrapper to /usr/local/bin/protoc so it's available system-wide during CI builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade protobuf and grpcio dependencies to use floating version ranges, improving flexibility for downstream users.
Changes
Dependency updates:
protobuf:==6.32.1→>=6.33,<7grpcio:==1.75.1→>=1.76grpcio-tools:==1.75.1→>=1.76Files modified:
pyproject.tomlcontrib/pyln-grpc-proto/pyproject.tomlcontrib/pyln-testing/pyproject.tomluv.lockRemoved:
contrib/pyln-grpc-proto/uv.lock- stale lock file that referenced oldprotobuf3packageCI changes:
.github/scripts/setup.shRationale
Using floating version ranges allows downstream users of
pyln-grpc-prototo avoid dependency conflicts when other libraries depend on specific protobuf versions. The generated protobuf code (for 6.31.1) is compatible with protobuf 6.33.x runtime.