pytest: speed up test_sql significantly.#8886
Open
rustyrussell wants to merge 1 commit intoElementsProject:masterfrom
Open
pytest: speed up test_sql significantly.#8886rustyrussell wants to merge 1 commit intoElementsProject:masterfrom
rustyrussell wants to merge 1 commit intoElementsProject:masterfrom
Conversation
It uses the hold_invoice plugin to ensure that an HTLC is in flight, but it tells it to hold the HTLC for "TIMEOUT * 2" which is a big number under CI. Reduce it to sqrt(TIMEOUT + 1) * 2, which works for local testing (I run with TIMEOUT=10) and still should be enough for CI (TIMEOUT=180). Christian reported that the test took 763.00s (!!) under CI. On my build machine (TIMEOUT=90): Before: 383.00s After: 64.38s Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
speed-up-sql-test
branch
from
06af183 to
4ca3207
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It uses the hold_invoice plugin to ensure that an HTLC is in flight, but it tells it to hold the HTLC for "TIMEOUT * 2" which is a big number under CI.
Reduce it to sqrt(TIMEOUT + 1) * 2, which works for local testing (I run with TIMEOUT=10) and still should be enough for CI (TIMEOUT=180).
Christian reported that the test took 763.00s (!!) under CI.
Changelog-None: tests only